From patchwork Wed Jan 18 03:07:19 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 716490 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3v3Bjd4Ds9z9sxN for ; Wed, 18 Jan 2017 14:07:49 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.b="cSvIl9EP"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751526AbdARDHr (ORCPT ); Tue, 17 Jan 2017 22:07:47 -0500 Received: from mail-pg0-f44.google.com ([74.125.83.44]:35729 "EHLO mail-pg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751485AbdARDHo (ORCPT ); Tue, 17 Jan 2017 22:07:44 -0500 Received: by mail-pg0-f44.google.com with SMTP id 194so239940pgd.2 for ; Tue, 17 Jan 2017 19:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id; bh=l7up9oOD306kQ0DaIYU+jwZ/5+yctnVo3fYuz/rlvCc=; b=cSvIl9EPhBEV7VExdI8LM0iYQ6rBM71Vf5hmN83Pbar7ufbyRk33OFSj9s2PpWgr0J SJG1ILy7N5wY2cvRmYY/kkt2IOdt1Qvnvo5GOy2YgPQWioauADby1RVZUhWG/pfybCV5 rftNjM8H3fCQhH9A+kroBBnym71TgsrFdWjx4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=l7up9oOD306kQ0DaIYU+jwZ/5+yctnVo3fYuz/rlvCc=; b=G6b9iJUWwS+goqPnqgHTbvcYOOig1M03mPaTgxFX7JcLcXxaga7kyy7HFijWHltjVI Emh3xHGQtCe8On225IsXH1hnGBptLdPmwOIJjgLF2QmxdXvAOit8RPnSgLcEF9IqSnOK lKnM96KrJKjznXX2c/LwJGYtfUoW78tIWMk+PWa7nsT3AnsUPDwTkN1chbwmxY9/CUiP nU60Y3Pdon9BTnL+3ODsZ+R1Zx/zGCgc0NrYlZfHN++VaV9sN2uxbLI5FdtwFP7jmbY0 OGca8oUIVgARKeG7weGnWvOKfqxOtX8f4n3jlpCi47Il0v7qPNv5QlMeLs0+VkYD9CGj XNLw== X-Gm-Message-State: AIkVDXKJz25kld2dtlSQ+olElhG6kokf516fpV7bIH4fCVOaQGrfCsXIMOOFKPy+RBAaV4zk X-Received: by 10.99.178.21 with SMTP id x21mr1312762pge.48.1484708848629; Tue, 17 Jan 2017 19:07:28 -0800 (PST) Received: from localhost.broadcom.com ([192.19.255.250]) by smtp.gmail.com with ESMTPSA id b69sm49678029pfd.90.2017.01.17.19.07.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Jan 2017 19:07:28 -0800 (PST) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org, andrew.gospodarek@broadcom.com Subject: [PATCH net] bnxt_en: Fix "uninitialized variable" bug in TPA code path. Date: Tue, 17 Jan 2017 22:07:19 -0500 Message-Id: <1484708839-11745-1-git-send-email-michael.chan@broadcom.com> X-Mailer: git-send-email 1.8.3.1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org In the TPA GRO code path, initialize the tcp_opt_len variable to 0 so that it will be correct for packets without TCP timestamps. The bug caused the SKB fields to be incorrectly set up for packets without TCP timestamps, leading to these packets being rejected by the stack. Reported-by: Andy Gospodarek Acked-by: Andy Gospodarek Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.c b/drivers/net/ethernet/broadcom/bnxt/bnxt.c index 9608cb4..53e686f 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -1099,7 +1099,7 @@ static struct sk_buff *bnxt_gro_func_5730x(struct bnxt_tpa_info *tpa_info, { #ifdef CONFIG_INET struct tcphdr *th; - int len, nw_off, tcp_opt_len; + int len, nw_off, tcp_opt_len = 0; if (tcp_ts) tcp_opt_len = 12;