From patchwork Mon Jan 9 19:18:01 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 712914 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3ty4gN3S4Lz9t0Z for ; Tue, 10 Jan 2017 06:18:08 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="tT/NSOyY"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423203AbdAITSE (ORCPT ); Mon, 9 Jan 2017 14:18:04 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33871 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752180AbdAITSD (ORCPT ); Mon, 9 Jan 2017 14:18:03 -0500 Received: by mail-pf0-f194.google.com with SMTP id y143so3980428pfb.1 for ; Mon, 09 Jan 2017 11:18:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=MI0CkIjj+/VF20vF2kDNt9h3H8cfydKYk+iVRHZewDc=; b=tT/NSOyYqd18CaRCVHzBrXmG+qruOvtfx27zbHYZLWAVUKiS/wnd+WcZRqFPgJtfFQ 8EmZetbaqKQt2qy8topMCr6kNOfnXD4ojk0LegqP09tTUskETodqKiJTkL5iZ8AbB/Rj Od8c/ZA5iVfixKDnMHkASykR4pIdr0q1BiBKlkuKg5e3TnsXaCrDNG1Bspwj21hd5Q2A OGB37Dfrzc8ORFJQpbUMP3XYeDNpwiYSJrWZNjjo2SJZhaVStNGkNz0kLdWhQVbn5ulx bz02SUxoZdfjsoIKJN5dZD/wSGmEpWkc52EDIccP+9YQ+WVvXD0fs6ecErP2lTOP5kXz +crw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=MI0CkIjj+/VF20vF2kDNt9h3H8cfydKYk+iVRHZewDc=; b=lM/j2/HwbzLyzbKAuvsBiQjDPyAF69CoARzE4AfJ6Ir8i3NeeXgIwRmY5PbXaCn0oq XIqzWtjM7WQ/QuiTnbIL/Ps/HK50R8Ot5VOEbQ57RMCjWNyh78p46o74l0SASCOBeMUr 8Gd49fznub00ZtEfD3LgGrMKnysofta/rb0RMEnVtKzQuWP3kB9ClOM/dFEICH1zAPdg SoF//pSE6aKb1gsshTyrp57rILbglKvdGyBHbsyxZCnAWKM4JikF95SD5kMUYHQOZuBI nZm1kTLuqDtbBJBPxnqiuJBaD3djB7YgnBYKMwIIbpg0Zl7iKqwAsZ3Ub1crpl4Vd7e7 EYEw== X-Gm-Message-State: AIkVDXIad+Ys9E/ldPbGErBkzWwBRLlCcVnMiqwWXu7VXUhPwoaYEoQz6WvAnZO1Hoazzw== X-Received: by 10.99.95.151 with SMTP id t145mr26861513pgb.75.1483989483022; Mon, 09 Jan 2017 11:18:03 -0800 (PST) Received: from ?IPv6:2620:0:1000:1704:44dc:138e:8d63:9c5e? ([2620:0:1000:1704:44dc:138e:8d63:9c5e]) by smtp.googlemail.com with ESMTPSA id e11sm182828248pgp.10.2017.01.09.11.18.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 09 Jan 2017 11:18:02 -0800 (PST) Message-ID: <1483989481.21472.16.camel@edumazet-glaptop3.roam.corp.google.com> Subject: [PATCH net] net: skb_flow_get_be16() can be static From: Eric Dumazet To: David Miller Cc: netdev Date: Mon, 09 Jan 2017 11:18:01 -0800 X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet Removes following sparse complain : net/core/flow_dissector.c:70:8: warning: symbol 'skb_flow_get_be16' was not declared. Should it be static? Fixes: 972d3876faa8 ("flow dissector: ICMP support") Signed-off-by: Eric Dumazet --- net/core/flow_dissector.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index fe4e1531976c3a36127b6ad4af33f24534af4c52..1b7673aac59d51a5f8b5ef3f2076f1440c017fae 100644 --- a/net/core/flow_dissector.c +++ b/net/core/flow_dissector.c @@ -67,8 +67,8 @@ EXPORT_SYMBOL(skb_flow_dissector_init); * The function will try to retrieve a be32 entity at * offset poff */ -__be16 skb_flow_get_be16(const struct sk_buff *skb, int poff, void *data, - int hlen) +static __be16 skb_flow_get_be16(const struct sk_buff *skb, int poff, + void *data, int hlen) { __be16 *u, _u;