From patchwork Wed Nov 30 10:09:01 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 700947 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3tTGS56WrQz9vFx for ; Wed, 30 Nov 2016 21:12:21 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b="jrRj6+Jm"; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756315AbcK3KKD (ORCPT ); Wed, 30 Nov 2016 05:10:03 -0500 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35878 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755352AbcK3KJR (ORCPT ); Wed, 30 Nov 2016 05:09:17 -0500 Received: by mail-wm0-f65.google.com with SMTP id m203so28537601wma.3 for ; Wed, 30 Nov 2016 02:09:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=2R4IuUtZugXW6ExvMYAodzGgv8Y7lu/JFplwTN3FHj4=; b=jrRj6+Jmc8GuHWJPJ0/gLTgTiBtE0I05dB/1wcPFeu/L8SDo3WBkZtID3zltaaol1u 2k1C7E4fD5kfZozI03w4Fl18oRG1dCYXs8XndAu/Lv81Gz6pBKv1N8rMvVYsVnnpRjaF U4HSQdFERXPtH5ugmKDP/ifBQcNXFBi0yRYlhlYaoNnSjXwjvZ9i9GP4sPD2Uxvf1NYT PdOdElbMRVGwuJjCuy3L1fxHy0QuJzr0cyIgn6WGHjWMhc+EzfOBXknZymGgQ17m0k2Y oLAJu+OHiOWj+mVuiW+osVxUwfzffqdgdVPdE/1MjMfBaQExYdR7IdnhgLWch0Lii7Kh 7wFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=2R4IuUtZugXW6ExvMYAodzGgv8Y7lu/JFplwTN3FHj4=; b=SwGdZEYYUpVlmjLomCJO5gJmKwHmELVM66zEHRTO441siNqsDJK5UVQ3CoLVDsdVxg 7mroPajVXECCUzY7x6cfTn10agSejRiFdA1TKNXSBLuQLjiSLWfyD1UtfNJA1y3TP6ti fTD/LHuHxvQ8ghQHabeJIUrC913WOkwfkvQjp9vSUwJv+6GtgBOdEjzMRbNj7JjJ4gcJ yhkaUqxujvNzstXRlz5P3Cbn71lNV01HsdseKUkrJVt1Oi3xbrYzX4rLzb/mVFsHC6NF Q56zUk0GuQAXD8IgooFuXVh2r3TDI/uuBNHJkvcQkJaBxLw91r6rpfCH/3bM8/48kYlK Xxpw== X-Gm-Message-State: AKaTC03Ir+fZYQ9/pMhcoummQWH9GoUdfcsMp/I4yHI3XBFzs4+Hoj99rGeXiF4v2TBV6A== X-Received: by 10.28.63.150 with SMTP id m144mr8955113wma.96.1480500556498; Wed, 30 Nov 2016 02:09:16 -0800 (PST) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id l74sm7165431wmg.2.2016.11.30.02.09.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 30 Nov 2016 02:09:16 -0800 (PST) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, idosch@mellanox.com, eladr@mellanox.com, yotamg@mellanox.com, nogahf@mellanox.com, arkadis@mellanox.com, ogerlitz@mellanox.com, roopa@cumulusnetworks.com, dsa@cumulusnetworks.com, nikolay@cumulusnetworks.com, andy@greyhouse.net, vivien.didelot@savoirfairelinux.com, andrew@lunn.ch, f.fainelli@gmail.com, alexander.h.duyck@intel.com, hannes@stressinduktion.org, kaber@trash.net Subject: [patch net-next v3 07/12] ipv4: fib: Convert FIB notification chain to be atomic Date: Wed, 30 Nov 2016 11:09:01 +0100 Message-Id: <1480500546-2544-8-git-send-email-jiri@resnulli.us> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1480500546-2544-1-git-send-email-jiri@resnulli.us> References: <1480500546-2544-1-git-send-email-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ido Schimmel In order not to hold RTNL for long periods of time we're going to dump the FIB tables using RCU. Convert the FIB notification chain to be atomic, as we can't block in RCU critical sections. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- net/ipv4/fib_trie.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/net/ipv4/fib_trie.c b/net/ipv4/fib_trie.c index 026f309..9bfce0d 100644 --- a/net/ipv4/fib_trie.c +++ b/net/ipv4/fib_trie.c @@ -84,17 +84,17 @@ #include #include "fib_lookup.h" -static BLOCKING_NOTIFIER_HEAD(fib_chain); +static ATOMIC_NOTIFIER_HEAD(fib_chain); int register_fib_notifier(struct notifier_block *nb) { - return blocking_notifier_chain_register(&fib_chain, nb); + return atomic_notifier_chain_register(&fib_chain, nb); } EXPORT_SYMBOL(register_fib_notifier); int unregister_fib_notifier(struct notifier_block *nb) { - return blocking_notifier_chain_unregister(&fib_chain, nb); + return atomic_notifier_chain_unregister(&fib_chain, nb); } EXPORT_SYMBOL(unregister_fib_notifier); @@ -102,7 +102,7 @@ int call_fib_notifiers(struct net *net, enum fib_event_type event_type, struct fib_notifier_info *info) { info->net = net; - return blocking_notifier_call_chain(&fib_chain, event_type, info); + return atomic_notifier_call_chain(&fib_chain, event_type, info); } static int call_fib_entry_notifiers(struct net *net,