Message ID | 1478790392-13028-1-git-send-email-mrv@mojatatu.com |
---|---|
State | Changes Requested, archived |
Delegated to: | stephen hemminger |
Headers | show |
On Thu, 10 Nov 2016 10:06:32 -0500 Roman Mashak <mrv@mojatatu.com> wrote: > Resending patch after fixing indentation and spaces. > > Signed-off-by: Roman Mashak <mrv@mojatatu.com> > Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com> iproute2 uses kernel coding style. This patch fails basic checkpatch. WARNING: suspect code indent for conditional statements (8, 11) #31: FILE: tc/tc_qdisc.c:241: + if (!show_raw) { + fprintf(fp, "qdisc %s %x: ", rta_getattr_str(tb[TCA_KIND]), total: 0 errors, 1 warnings, 15 lines checked
diff --git a/tc/tc_qdisc.c b/tc/tc_qdisc.c index 93c9a4c..a8c8386 100644 --- a/tc/tc_qdisc.c +++ b/tc/tc_qdisc.c @@ -231,7 +231,15 @@ int print_qdisc(const struct sockaddr_nl *who, if (n->nlmsg_type == RTM_DELQDISC) fprintf(fp, "deleted "); - fprintf(fp, "qdisc %s %x: ", rta_getattr_str(tb[TCA_KIND]), t->tcm_handle>>16); + if (!show_raw) { + fprintf(fp, "qdisc %s %x: ", rta_getattr_str(tb[TCA_KIND]), + t->tcm_handle >> 16); + } else { + fprintf(fp, "qdisc %s %x:[%08x] ", + rta_getattr_str(tb[TCA_KIND]), + t->tcm_handle >> 16, t->tcm_handle); + } + if (filter_ifindex == 0) fprintf(fp, "dev %s ", ll_index_to_name(t->tcm_ifindex)); if (t->tcm_parent == TC_H_ROOT)