diff mbox

[iproute2,1/1] tc: print raw qdisc handle.

Message ID 1478485019-9438-1-git-send-email-mrv@mojatatu.com
State Changes Requested, archived
Delegated to: stephen hemminger
Headers show

Commit Message

Roman Mashak Nov. 7, 2016, 2:16 a.m. UTC
Signed-off-by: Roman Mashak <mrv@mojatatu.com>
Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
---
 tc/tc_qdisc.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

Comments

Sergei Shtylyov Nov. 7, 2016, 1:13 p.m. UTC | #1
Hello.

On 11/7/2016 5:16 AM, Roman Mashak wrote:

> Signed-off-by: Roman Mashak <mrv@mojatatu.com>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>
> ---
>  tc/tc_qdisc.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/tc/tc_qdisc.c b/tc/tc_qdisc.c
> index a63c476..9b06b8f 100644
> --- a/tc/tc_qdisc.c
> +++ b/tc/tc_qdisc.c
> @@ -238,7 +238,14 @@ int print_qdisc(const struct sockaddr_nl *who,
>  	if (n->nlmsg_type == RTM_DELQDISC)
>  		fprintf(fp, "deleted ");
>
> -	fprintf(fp, "qdisc %s %x: ", rta_getattr_str(tb[TCA_KIND]), t->tcm_handle>>16);
> +	if (!show_raw) {
> +	   fprintf(fp, "qdisc %s %x: ", rta_getattr_str(tb[TCA_KIND]),
> +			t->tcm_handle >> 16);
> +	} else {
> +	   fprintf(fp, "qdisc %s %x:[%08x] ", rta_getattr_str(tb[TCA_KIND]),
> +			t->tcm_handle >> 16, t->tcm_handle);

    The above/below code seems to indent with tabs only, why are you using spaces?

> +	}
> +
>  	if (filter_ifindex == 0)
>  		fprintf(fp, "dev %s ", ll_index_to_name(t->tcm_ifindex));
>  	if (t->tcm_parent == TC_H_ROOT)

MBR, Sergei
diff mbox

Patch

diff --git a/tc/tc_qdisc.c b/tc/tc_qdisc.c
index a63c476..9b06b8f 100644
--- a/tc/tc_qdisc.c
+++ b/tc/tc_qdisc.c
@@ -238,7 +238,14 @@  int print_qdisc(const struct sockaddr_nl *who,
 	if (n->nlmsg_type == RTM_DELQDISC)
 		fprintf(fp, "deleted ");
 
-	fprintf(fp, "qdisc %s %x: ", rta_getattr_str(tb[TCA_KIND]), t->tcm_handle>>16);
+	if (!show_raw) {
+	   fprintf(fp, "qdisc %s %x: ", rta_getattr_str(tb[TCA_KIND]),
+			t->tcm_handle >> 16);
+	} else {
+	   fprintf(fp, "qdisc %s %x:[%08x] ", rta_getattr_str(tb[TCA_KIND]),
+			t->tcm_handle >> 16, t->tcm_handle);
+	}
+
 	if (filter_ifindex == 0)
 		fprintf(fp, "dev %s ", ll_index_to_name(t->tcm_ifindex));
 	if (t->tcm_parent == TC_H_ROOT)