From patchwork Tue Nov 1 14:08:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Roi Dayan X-Patchwork-Id: 689914 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3t7Y4H3QVcz9t14 for ; Wed, 2 Nov 2016 01:08:47 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966220AbcKAOIo (ORCPT ); Tue, 1 Nov 2016 10:08:44 -0400 Received: from mail-il-dmz.mellanox.com ([193.47.165.129]:35503 "EHLO mellanox.co.il" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966187AbcKAOIi (ORCPT ); Tue, 1 Nov 2016 10:08:38 -0400 Received: from Internal Mail-Server by MTLPINE1 (envelope-from roid@mellanox.com) with ESMTPS (AES256-SHA encrypted); 1 Nov 2016 16:08:31 +0200 Received: from dev-r-vrt-189.mtr.labs.mlnx (dev-r-vrt-189.mtr.labs.mlnx [10.212.189.1]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id uA1E8U2c021641; Tue, 1 Nov 2016 16:08:30 +0200 From: Roi Dayan To: "David S. Miller" Cc: netdev@vger.kernel.org, Jiri Pirko , Roi Dayan Subject: [PATCH net-next 1/2] net/sched: cls_flower: add missing unbind call when destroying flows Date: Tue, 1 Nov 2016 16:08:28 +0200 Message-Id: <1478009309-63180-2-git-send-email-roid@mellanox.com> X-Mailer: git-send-email 1.8.4.3 In-Reply-To: <1478009309-63180-1-git-send-email-roid@mellanox.com> References: <1478009309-63180-1-git-send-email-roid@mellanox.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org tcf_unbind was called in fl_delete but was missing in fl_destroy when force deleting flows. Fixes: 77b9900ef53a ('tc: introduce Flower classifier') Signed-off-by: Roi Dayan Reviewed-by: Jiri Pirko --- net/sched/cls_flower.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/cls_flower.c b/net/sched/cls_flower.c index f6f40fb..a5f6370 100644 --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -280,6 +280,7 @@ static bool fl_destroy(struct tcf_proto *tp, bool force) list_for_each_entry_safe(f, next, &head->filters, list) { fl_hw_destroy_filter(tp, (unsigned long)f); list_del_rcu(&f->list); + tcf_unbind_filter(tp, &f->res); call_rcu(&f->rcu, fl_destroy_filter); } RCU_INIT_POINTER(tp->root, NULL);