From patchwork Wed Sep 7 04:31:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrei Vagin X-Patchwork-Id: 666807 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sTVsW5zTKz9sdn for ; Wed, 7 Sep 2016 14:31:27 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=Zr+2Ikyr; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752707AbcIGEbY (ORCPT ); Wed, 7 Sep 2016 00:31:24 -0400 Received: from mail-lf0-f67.google.com ([209.85.215.67]:36673 "EHLO mail-lf0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751125AbcIGEbX (ORCPT ); Wed, 7 Sep 2016 00:31:23 -0400 Received: by mail-lf0-f67.google.com with SMTP id j41so160665lfi.3 for ; Tue, 06 Sep 2016 21:31:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=hLF25pdePT9jEtbj6d9qe9MnJJH78xZDnEkmizfiv1s=; b=Zr+2Ikyr7NPze1AbThs4unds1ZkKiBKnpqnu1Ge5qsG+7/8vGPxgokZXfth33FZaKP fDtxrTUUVlj5xnTBMWjzSeZ0VddEaEf5a/1wN4MM7XedP6fZPKJbImvgQN/ZsQqZhYha V2jaOGLE58KwyDGUiCdae3hMjd2FOu15FbUBCeRq5CVnSRqc79KmIQjcMmAw1Kj7R43n +qah2rquBYBXkruKqyL/rfjV7YKE0NxEQqyv5a6KTcoB4DQHU7GxQh9JOHb+DJQ1PboJ 0PdHK+csTfye29cEuNKH1bhxXm5nWBHRKt8l+8taZzrqltdY30aBdBScWx/3qPXtTJob qb2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=hLF25pdePT9jEtbj6d9qe9MnJJH78xZDnEkmizfiv1s=; b=gQHjJEFbOfKkKyLgJpJ5s+G4/mEyoXak0bWgflUBWPerlI+AbT4Z3NcTbHEUOH3oOp O6JM7nTHbaXYou5CRBFFwtnsDdb/Fdi+4n2919jXwJwPVDtAXrXbkilt4ye5sYWh2mkN lfaujUQcHC0hhMms6BnmdIkuCaq2ZC+zl4usHIXDOH+GSTSTS0UqmosNjpdUuwKUO7tp lmGL+v5apHL4USV/H1j6f1eFrzKY7HHYevsE7pVDip7rBZgY4ja+cRIpmfUMtAIZnLrD YSsKnO1a8sfXrf02GeAqbbK50cZU9Fb3yKRGlT0af74nnwCMMA5ORTbH8mTpZ7G9vlGM ++XQ== X-Gm-Message-State: AE9vXwMbVW1F825eHNtyXUTSeEBpW7ab8s4nZ/Js+u9VwgswRLGg39Y6XPBntlFxv0BKYw== X-Received: by 10.25.163.205 with SMTP id m196mr12930299lfe.5.1473222681322; Tue, 06 Sep 2016 21:31:21 -0700 (PDT) Received: from laptop.sw.ru (swsoft-msk-nat.sw.ru. [195.214.232.10]) by smtp.gmail.com with ESMTPSA id r190sm6225853lfg.49.2016.09.06.21.31.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 06 Sep 2016 21:31:20 -0700 (PDT) From: Andrei Vagin To: netdev@vger.kernel.org Cc: "David S. Miller" , Andrei Vagin , Herbert Xu Subject: [PATCH net-next v2] netlink: don't forget to release a rhashtable_iter structure Date: Tue, 6 Sep 2016 21:31:17 -0700 Message-Id: <1473222677-24761-1-git-send-email-avagin@openvz.org> X-Mailer: git-send-email 2.5.5 In-Reply-To: <20160906.174137.1869816645707925029.davem@davemloft.net> References: <20160906.174137.1869816645707925029.davem@davemloft.net> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This bug was detected by kmemleak: unreferenced object 0xffff8804269cc3c0 (size 64): comm "criu", pid 1042, jiffies 4294907360 (age 13.713s) hex dump (first 32 bytes): a0 32 cc 2c 04 88 ff ff 00 00 00 00 00 00 00 00 .2.,............ 00 01 00 00 00 00 ad de 00 02 00 00 00 00 ad de ................ backtrace: [] kmemleak_alloc+0x4a/0xa0 [] kmem_cache_alloc_trace+0x10f/0x280 [] __netlink_diag_dump+0x26c/0x290 [netlink_diag] v2: don't remove a reference on a rhashtable_iter structure to release it from netlink_diag_dump_done Cc: Herbert Xu Fixes: ad202074320c ("netlink: Use rhashtable walk interface in diag dump") Signed-off-by: Andrei Vagin Acked-by: Herbert Xu --- net/netlink/diag.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/netlink/diag.c b/net/netlink/diag.c index 3e3e253..b2f0e98 100644 --- a/net/netlink/diag.c +++ b/net/netlink/diag.c @@ -127,7 +127,6 @@ stop: goto done; rhashtable_walk_exit(hti); - cb->args[2] = 0; num++; mc_list: