From patchwork Thu Aug 25 22:23:41 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Florian Fainelli X-Patchwork-Id: 662966 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sKzH03NCmz9sBM for ; Fri, 26 Aug 2016 08:23:56 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=VlacTnyP; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758203AbcHYWXw (ORCPT ); Thu, 25 Aug 2016 18:23:52 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:35999 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758054AbcHYWXv (ORCPT ); Thu, 25 Aug 2016 18:23:51 -0400 Received: by mail-pa0-f67.google.com with SMTP id ez1so3709045pab.3 for ; Thu, 25 Aug 2016 15:23:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=JOamIfc5Kp7YPH96XTXprTfn8TYBrugoupi9wOpyYzs=; b=VlacTnyPRQwvld6BSXz1PbCkuFMfy1qasr+euqos7LEgegvGuQKDs9cqKfBJrR7/TU QkmPmLiZ+X3Eux2QDiojD+0MnxT9qzCTrKwMoLp4IC1KJayw+/ZRnh7VFDut1rWwmPot 4Me2Zyl9J3hZMCSv3ac7opXX+XUJNKfBzxAjHVR8HcFGfUz8B5hTef+dXxjIaLsJyyCh GXTR95JVTPECz5DL2uJE782DxjZlgmI1Umdvgymc9NuUA6skXb9KxTvDv9yX8k3afF4w mJeAGCegg1Jytu6NM6oDpPIVw9XX68vVPmXbd98PExQkCe7pAaLe4/AphItCVGG1ffPt qfqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=JOamIfc5Kp7YPH96XTXprTfn8TYBrugoupi9wOpyYzs=; b=OYFnqBdtDAspZ4YM4wHTQHclhZxuQGpytR/Pd7hzcqhrHqSJgD/+2Y+Sj01+OlW1sT thI1TbCfZ28+E0ct6viYAzNk9rbhVgLHF2GGoBrYCdQ6zurHm+q8/h73/Jd3apjpVJnL BgVwMUYZAKVFIxFCDxcvjXVoQgOtxEs2sfQO+xUjVKDyIocf0FVc8zELl5feR1hflLa6 6pQk2kTo/Nilsm8MtHCcaxTIg3W/wlgvG8Z/Jk4G5qATBz1tZwa/WNKlp9BltppqHWdk wsFSU0ozKuTDPAD6106Nfu+uW6mXbRA+ey/z/Hs25OD6paFhcAdeUqYWTT6JWQVzsJsx /qlg== X-Gm-Message-State: AE9vXwPd1bH5T3OPI/hN+jRVI0l1mRHTZ+TcZWVMG7s7SmQp1oYnKUZuaQWYhUq3k2sP7A== X-Received: by 10.66.78.5 with SMTP id x5mr20501432paw.108.1472163830697; Thu, 25 Aug 2016 15:23:50 -0700 (PDT) Received: from fainelli-desktop.broadcom.com (5520-maca-inet1-outside.broadcom.com. [216.31.211.11]) by smtp.gmail.com with ESMTPSA id i7sm23232483paf.9.2016.08.25.15.23.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 25 Aug 2016 15:23:50 -0700 (PDT) From: Florian Fainelli To: netdev@vger.kernel.org Cc: davem@davemloft.net, andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, Florian Fainelli Subject: [PATCH net-next] net: dsa: bcm_sf2: Utilize mask clear/set helpers in bcm_sf2_intr_disable Date: Thu, 25 Aug 2016 15:23:41 -0700 Message-Id: <1472163821-7142-1-git-send-email-f.fainelli@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org And while at it, remove the unecessary writing of zeroes to the CPU_MASK_CLEAR register since it has no functional use. Signed-off-by: Florian Fainelli --- drivers/net/dsa/bcm_sf2.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c index 220e5d1948ca..2abeea193843 100644 --- a/drivers/net/dsa/bcm_sf2.c +++ b/drivers/net/dsa/bcm_sf2.c @@ -1027,12 +1027,10 @@ static int bcm_sf2_sw_rst(struct bcm_sf2_priv *priv) static void bcm_sf2_intr_disable(struct bcm_sf2_priv *priv) { - intrl2_0_writel(priv, 0xffffffff, INTRL2_CPU_MASK_SET); + intrl2_0_mask_set(priv, 0xffffffff); intrl2_0_writel(priv, 0xffffffff, INTRL2_CPU_CLEAR); - intrl2_0_writel(priv, 0, INTRL2_CPU_MASK_CLEAR); - intrl2_1_writel(priv, 0xffffffff, INTRL2_CPU_MASK_SET); + intrl2_1_mask_set(priv, 0xffffffff); intrl2_1_writel(priv, 0xffffffff, INTRL2_CPU_CLEAR); - intrl2_1_writel(priv, 0, INTRL2_CPU_MASK_CLEAR); } static void bcm_sf2_identify_ports(struct bcm_sf2_priv *priv,