From patchwork Wed Aug 24 10:00:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 662183 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sK2rz0KTxz9snm for ; Wed, 24 Aug 2016 20:01:39 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b=DZIW2FQp; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932584AbcHXKBd (ORCPT ); Wed, 24 Aug 2016 06:01:33 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:32927 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932489AbcHXKBV (ORCPT ); Wed, 24 Aug 2016 06:01:21 -0400 Received: by mail-wm0-f68.google.com with SMTP id o80so1870637wme.0 for ; Wed, 24 Aug 2016 03:00:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=/y3biAxPUYAWfw/p4zCUau8iBAWvx6sLh3f8UqLYoV0=; b=DZIW2FQpd21EQ7GIbZE3j0wXddnzwtlL5VKuaHBcOMv5uHDD9XZaQ57m28WARkYSui 5ovvjOEzVNdoJP7Vq0saGBJ+Nl9Re+FN/Fx0gHzVpQV2/wSfWiKDQeUnpofo/9BZ/mW8 sV31fs07e8l1J9s9ZOlZC+MwltSwHY48jlSjq6x+2AhXPJVJNoUSjXJNRTR2d+/Ay8kQ 2+pYr/O6CCKpU8gGEnPL/arABr5Jnf9JV+TBOGfkEPuoPHPmIj30mlJaQ8vMzCyTL7aJ qif6tqYRAvXocrEoYvwXOHEOpUhN+hj4KfkabcPS9LjJVqKJHyKqR6BvMd3ojdgMtWfp oCxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=/y3biAxPUYAWfw/p4zCUau8iBAWvx6sLh3f8UqLYoV0=; b=itIZOEwR3s/1hAjD0FbrAIQ+CrESK4lxawEiT9o2G4baxjBofTS4JPehuf5G7xWm7N t1utOyIiUTRMAQn5ucIfcXGwR4jS4k8i7e+pOU2IGIjIIXFnMFo5zNV1qdaxRIxN2O+2 yVU4hjme29memOEoVSKprAg3hcUNNKbFGSMTwJRAHqhcnmMfxk2IK6bAPAD3SJPy6bN2 lInhVyA6XtZdEFrfOHhM2MJ1CzHmR4UNrIr3Y1pXss/2AHqgdl0hLBVg5OvhCkL+52fI +fBVMCLgXhmnRkskeXt6VUeozCDxEzHMcucByUaxxNNemRUHXqQPUqtFGZH9YDEf/dqa nc4A== X-Gm-Message-State: AEkoousw8GQygTDTaLDrY7JicTW8rmQnj66z+kyz/Xr4CqmHGjt0WIetnoUFXeYcJepTFg== X-Received: by 10.28.74.221 with SMTP id n90mr23042439wmi.16.1472032840167; Wed, 24 Aug 2016 03:00:40 -0700 (PDT) Received: from localhost (ip-78-45-162-30.net.upcbroadband.cz. [78.45.162.30]) by smtp.gmail.com with ESMTPSA id q137sm32773686wmd.19.2016.08.24.03.00.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 24 Aug 2016 03:00:39 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, idosch@mellanox.com, eladr@mellanox.com, yotamg@mellanox.com, nogahf@mellanox.com, ogerlitz@mellanox.com Subject: [patch net-next 7/7] mlxsw: spectrum: Don't set learning when creating vPorts Date: Wed, 24 Aug 2016 12:00:29 +0200 Message-Id: <1472032829-6322-8-git-send-email-jiri@resnulli.us> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1472032829-6322-1-git-send-email-jiri@resnulli.us> References: <1472032829-6322-1-git-send-email-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Ido Schimmel Before commit 99724c18fc66 ("mlxsw: spectrum: Introduce support for router interfaces") we used to assign vFIDs to the created vPorts. Since these vPorts were used for slow path traffic we had to disable learning for them, as it doesn't make sense to have it enabled. This is no longer the case and now vPorts are either used for router interfaces (for which learning is disabled by the firmware) or bridge ports (for which learning is explicitly enabled by the driver). Therefore, we can remove the learning configuration upon vPort creation. Signed-off-by: Ido Schimmel Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/spectrum.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c index 3820317..2713a64 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum.c +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum.c @@ -981,10 +981,6 @@ static int mlxsw_sp_port_add_vid(struct net_device *dev, goto err_port_vp_mode_trans; } - err = mlxsw_sp_port_vid_learning_set(mlxsw_sp_vport, vid, false); - if (err) - goto err_port_vid_learning_set; - err = mlxsw_sp_port_vlan_set(mlxsw_sp_vport, vid, vid, true, untagged); if (err) goto err_port_add_vid; @@ -992,8 +988,6 @@ static int mlxsw_sp_port_add_vid(struct net_device *dev, return 0; err_port_add_vid: - mlxsw_sp_port_vid_learning_set(mlxsw_sp_vport, vid, true); -err_port_vid_learning_set: if (list_is_singular(&mlxsw_sp_port->vports_list)) mlxsw_sp_port_vlan_mode_trans(mlxsw_sp_port); err_port_vp_mode_trans: @@ -1020,8 +1014,6 @@ static int mlxsw_sp_port_kill_vid(struct net_device *dev, mlxsw_sp_port_vlan_set(mlxsw_sp_vport, vid, vid, false, false); - mlxsw_sp_port_vid_learning_set(mlxsw_sp_vport, vid, true); - /* Drop FID reference. If this was the last reference the * resources will be freed. */