From patchwork Tue Aug 23 17:20:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rami Rosen X-Patchwork-Id: 661960 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sJcfc51xXz9sDf for ; Wed, 24 Aug 2016 03:21:12 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=0CGWUzf/; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753017AbcHWRUa (ORCPT ); Tue, 23 Aug 2016 13:20:30 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36307 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752228AbcHWRU1 (ORCPT ); Tue, 23 Aug 2016 13:20:27 -0400 Received: by mail-wm0-f68.google.com with SMTP id i138so18950808wmf.3 for ; Tue, 23 Aug 2016 10:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=vMhP66H8EeU+LgShN+p9vu6wk90Q60OMC6QU0VA3GDc=; b=0CGWUzf/xngIFVLMhoDo3sbfHAhmb6PmAMzjoqdteW/BWA4M+vU7xg17EuD8lZ3J1R yxaDN2zSmAS6gnqLpQrj9bp21/Yu+2ZrTlMAq7zTot5dZ5XH9mgpj24bAQEXc2+OpsXm KUqwzsJtCmCU3KJE26vYLIwj4ZPi4L38EIInlFjfQh1MsZdMXYm9NaM/setTg8jmoHlS cQQwGR+7jL9Da/LRk+NGOQzJpfRmXg3FgKoTjxlxmfItnnx7teGQ5KpUQV0E8zcgyJF1 EEdF591b8Udda6pu8NDOYDLbz09+atQy0xxovB7g4EkowdCJxqtBC6cwJ1obEjOsq+6G CMAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=vMhP66H8EeU+LgShN+p9vu6wk90Q60OMC6QU0VA3GDc=; b=D8CFs27km41Gti55NDRqTxh8JcIJIP3+vrCZzGE30/WHyOSF0gI5mCWAxLyLyX6h86 UI6M8sUMuovuMSKW1hE4Xr0y9yySq7jzZlfBXDgzCnRmwFWqFYW19OX+7XlLKa6HGmFX m0bTxBf4xDl7LwJfHxe7uwZrhzzGUcAqZfp6DzwPAxx+hY6egdL7cO8sLQvNfHHwnHFC IELCM7xMZrEolnjruJWSUtBPv3EAi2jjcITaAaj7O0wwSsp4jd0HM39aa06LStg5YEHU 13iYn/uUKby7wfQVDi4a3VcWW66l7WDpDMnmTTVm3MHVhncceOcgkG9Z1xt2qo045A0U nlmw== X-Gm-Message-State: AEkoouuErQD9yUSMts14d3vSk8XnfIRKXzydUFd8v3MUW6pJuIshEUf5/TJ/PKydRVkcxQ== X-Received: by 10.28.26.69 with SMTP id a66mr21762541wma.8.1471972826533; Tue, 23 Aug 2016 10:20:26 -0700 (PDT) Received: from h.localdomain (bzq-79-176-119-237.red.bezeqint.net. [79.176.119.237]) by smtp.gmail.com with ESMTPSA id i80sm5548304wmf.11.2016.08.23.10.20.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Aug 2016 10:20:25 -0700 (PDT) From: Rami Rosen To: netdev@vger.kernel.org Cc: netanel@annapurnalabs.com, Rami Rosen Subject: [PATCH] net: ena: change the return type of ena_set_push_mode() to be void. Date: Tue, 23 Aug 2016 20:20:17 +0300 Message-Id: <1471972817-4103-1-git-send-email-ramirose@gmail.com> X-Mailer: git-send-email 2.4.3 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch changes the return type of ena_set_push_mode() to be void, as it always returns 0. Signed-off-by: Rami Rosen --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c index 5c536b8..bfeaec5 100644 --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c @@ -2681,8 +2681,8 @@ static int ena_calc_io_queue_num(struct pci_dev *pdev, return io_queue_num; } -static int ena_set_push_mode(struct pci_dev *pdev, struct ena_com_dev *ena_dev, - struct ena_com_dev_get_features_ctx *get_feat_ctx) +static void ena_set_push_mode(struct pci_dev *pdev, struct ena_com_dev *ena_dev, + struct ena_com_dev_get_features_ctx *get_feat_ctx) { bool has_mem_bar; @@ -2693,8 +2693,6 @@ static int ena_set_push_mode(struct pci_dev *pdev, struct ena_com_dev *ena_dev, ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_DEV; else ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; - - return 0; } static void ena_set_dev_offloads(struct ena_com_dev_get_features_ctx *feat, @@ -2913,11 +2911,7 @@ static int ena_probe(struct pci_dev *pdev, const struct pci_device_id *ent) goto err_free_region; } - rc = ena_set_push_mode(pdev, ena_dev, &get_feat_ctx); - if (rc) { - dev_err(&pdev->dev, "Invalid module param(push_mode)\n"); - goto err_device_destroy; - } + ena_set_push_mode(pdev, ena_dev, &get_feat_ctx); if (ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_DEV) { ena_dev->mem_bar = ioremap_wc(pci_resource_start(pdev, ENA_MEM_BAR),