diff mbox

[2/2] kaweth: fix oops upon failed memory allocation

Message ID 1471427969-2355-2-git-send-email-oneukum@suse.com
State Superseded, archived
Delegated to: David Miller
Headers show

Commit Message

Oliver Neukum Aug. 17, 2016, 9:59 a.m. UTC 
Just return an error upon failure.

Signed-off-by: Oliver Neukum <oneukum@suse.com>
---
 drivers/net/usb/kaweth.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Bjørn Mork Aug. 17, 2016, 1:15 p.m. UTC | #1 
Oliver Neukum <oneukum@suse.com> writes:

> Just return an error upon failure.
>
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> ---
>  drivers/net/usb/kaweth.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c
> index 37bf715..3cd6906 100644
> --- a/drivers/net/usb/kaweth.c
> +++ b/drivers/net/usb/kaweth.c
> @@ -1049,6 +1049,8 @@ static int kaweth_probe(
>  		/* Download the firmware */
>  		dev_info(dev, "Downloading firmware...\n");
>  		kaweth->firmware_buf = (__u8 *)__get_free_page(GFP_KERNEL);
> +		if (!kaweth->firmware_buf)
> +				return -ENOMEM;

Eh, that should be "goto err_free_netdev;", shouldn't it?



Bjørn
Oliver Neukum Aug. 17, 2016, 1:33 p.m. UTC | #2 
On Wed, 2016-08-17 at 15:15 +0200, Bjørn Mork wrote:
> Oliver Neukum <oneukum@suse.com> writes:

> Eh, that should be "goto err_free_netdev;", shouldn't it?

Right, thanks. Fixed version coming up.

	Regards
		Oliver
diff mbox

Patch

diff --git a/drivers/net/usb/kaweth.c b/drivers/net/usb/kaweth.c
index 37bf715..3cd6906 100644
--- a/drivers/net/usb/kaweth.c
+++ b/drivers/net/usb/kaweth.c
@@ -1049,6 +1049,8 @@  static int kaweth_probe(
 		/* Download the firmware */
 		dev_info(dev, "Downloading firmware...\n");
 		kaweth->firmware_buf = (__u8 *)__get_free_page(GFP_KERNEL);
+		if (!kaweth->firmware_buf)
+				return -ENOMEM;
 		if ((result = kaweth_download_firmware(kaweth,
 						      "kaweth/new_code.bin",
 						      100,