From patchwork Mon Aug 15 22:51:04 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 659440 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3sCrM91B3qz9t2X for ; Tue, 16 Aug 2016 08:51:17 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=BqvIqur1; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932284AbcHOWvO (ORCPT ); Mon, 15 Aug 2016 18:51:14 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:36155 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752258AbcHOWvN (ORCPT ); Mon, 15 Aug 2016 18:51:13 -0400 Received: by mail-pa0-f68.google.com with SMTP id ez1so4212034pab.3 for ; Mon, 15 Aug 2016 15:51:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yc5pm+OaC0+K27mba/KSnB2NV/cOb49L6K/ckazFUd0=; b=BqvIqur1WoVQfPemYP1fs8hQtz2k8EzmNcT4Q8MbpAxw84+JBnwJoetUOyKMlZV/6t nnKRD8Tim5MM+QzP6LvE5HcOm4ZJtPLlcRESxzaWAs+hzyjDoRmcxIfK39w3mK08j+fU mrA511GWVv1q4ICRILtttdbZLbIIHPnr4LjnDBTzdsPHybNIjTJQxYgREeSB/MK0wZoa L3f8xXG5W6Xc/PJSW9CgpeKsFeUcBF5H2Nsi16Jg/D36GAj39AoHN9ixyhr/SLPZSz8i bRnldXFzNSj98q1vH9Uu2dTxiJ8oyM7RgdEnU1u41+Zpop6r+6X9HouBj5474IBfGr11 fLEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yc5pm+OaC0+K27mba/KSnB2NV/cOb49L6K/ckazFUd0=; b=ld7CuSCCaT+sfe68ihtF/M5PbI0vyt9Nz14+xLsRAOIt8rFGB1ugD4FXqMXlQwcLoy F64ECQ4Ey/eOnHk0zSGh3sOStUdxr2MI9GBNaI0wCwqsquEk/N6r34wSc+bBvsjsp4vr 8lDA3okN66J+wleXAe4aHXfrP9D7f6ZVtDw94wTtHYGklEAhlc5HZwynSp/rAeOfhx6Y qspsqYFcHrllJhDTEyzNuH7qUe++Alv6SZUGqI5sJpac5mWu+ob4Fth9fl9QHqYgGvva rphkJivWyrsEovNNfEuEJ+49BYduYurtObBX5fz/xHuuYIxg0AX8fFPZeJpwXJ48bXeM IE4g== X-Gm-Message-State: AEkoouuDiYOjddfMXSxMv/R3KbMFTNmIRHSmanDuag8g6/VMMy5cKLK7pQkn3fRN3eVRZA== X-Received: by 10.66.170.44 with SMTP id aj12mr58368119pac.131.1471301472333; Mon, 15 Aug 2016 15:51:12 -0700 (PDT) Received: from bogon.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id d185sm33773010pfd.80.2016.08.15.15.51.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 15 Aug 2016 15:51:11 -0700 (PDT) From: Wei Yongjun To: Netanel Belgazal , Saeed Bishara , Zorik Machulsky , "David S. Miller" Cc: Wei Yongjun , netdev@vger.kernel.org Subject: [PATCH -next] net: ena: Fix error return code in ena_device_init() Date: Mon, 15 Aug 2016 22:51:04 +0000 Message-Id: <1471301464-24748-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix to return a negative error code from the invalid dma width error handling case instead of 0. Signed-off-by: Wei Yongjun --- drivers/net/ethernet/amazon/ena/ena_netdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/ethernet/amazon/ena/ena_netdev.c index 94790df..4cbe014 100644 --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c @@ -2329,6 +2329,7 @@ static int ena_device_init(struct ena_com_dev *ena_dev, struct pci_dev *pdev, dma_width = ena_com_get_dma_width(ena_dev); if (dma_width < 0) { dev_err(dev, "Invalid dma width value %d", dma_width); + rc = dma_width; goto err_mmio_read_less; }