From patchwork Mon Aug 8 20:46:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Wang X-Patchwork-Id: 656969 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3s7Tx96VK5z9svs for ; Tue, 9 Aug 2016 06:47:09 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=bkvjA3DP; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752550AbcHHUrE (ORCPT ); Mon, 8 Aug 2016 16:47:04 -0400 Received: from mail-pa0-f68.google.com ([209.85.220.68]:34310 "EHLO mail-pa0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752419AbcHHUrA (ORCPT ); Mon, 8 Aug 2016 16:47:00 -0400 Received: by mail-pa0-f68.google.com with SMTP id hh10so24606012pac.1 for ; Mon, 08 Aug 2016 13:47:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=n0drUnSkyu9+1sCKSp0dtfVMlOx40tME1UrxxFPMGEg=; b=bkvjA3DP+ud0oCBaU15VuULs4JAZYE4sdq60PbSSVAc/roE9/3/Fgd1luSs08FBNLY UaQyVsCUIXZ+tzLdpKeMrxHiEQuEdt7HTLi8u8win1kabzFAScc1RtwIJyDHbIdhlvDz v+4p+Ws7s9avOJ8hmxcRTb/fuv37nIezsCaTTbRgbCpuD1XF175LVMYDufZ30vm6I0gj XxFvnCByHekLfR18gTMv/HK+PFxNFdYTgzrlcwyidQQ3Yn6AjLsgzeF+N+EBMSZBuyXx o8A5kVbDwMRqSXJU8jGmGO4KqHlxbQzFZh3UEzTwQN9Av5ikTH2xREtUNP4G362EZ79g jcAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=n0drUnSkyu9+1sCKSp0dtfVMlOx40tME1UrxxFPMGEg=; b=m9xYQKl0bjViztPRSkVR205YqtF+BJxivz/PWqAH86YwLHuvCLs/gwfpqAxfZNKRvp C5Xa9PNg37Wb6n+99cK/a7Bk/mu91aeUhsYaJHlhW4YRgwSb7JgPwv6PuUPjyVWIDheV H0AGb5YgniY+TNDL3sJKEI5uR+vgEzeuJUlcCksYUoiuBR9Zc7fIgNqReCWQp+oHJmp+ 81AwmtZLq4ig8Z4e8nttDCJqFy5t5ZGkT3J2gjA5LlVQCOW3g1FKFqYMc8Uzx3Xk+tA1 OPZB9Rysbgen8/X36SNxPOQaO8b3Xq4maCF4vqT8nwLl4c9xJ15eUJsIkal0LtOgKw65 cqdw== X-Gm-Message-State: AEkoout5Xquirc0jesU3+65Cza+N6n41VcvW6oDR1RUkRQpLB9lwOj3r0ZtUqEmGMDP7iQ== X-Received: by 10.66.181.16 with SMTP id ds16mr166683556pac.102.1470689220006; Mon, 08 Aug 2016 13:47:00 -0700 (PDT) Received: from localhost.net ([8.25.197.26]) by smtp.gmail.com with ESMTPSA id t7sm50402177paz.21.2016.08.08.13.46.58 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 08 Aug 2016 13:46:58 -0700 (PDT) From: Cong Wang To: netdev@vger.kernel.org Cc: Cong Wang , Jamal Hadi Salim Subject: [Patch net 2/5] net_sched: remove an unnecessary list_del() Date: Mon, 8 Aug 2016 13:46:46 -0700 Message-Id: <1470689209-17682-3-git-send-email-xiyou.wangcong@gmail.com> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1470689209-17682-1-git-send-email-xiyou.wangcong@gmail.com> References: <1470689209-17682-1-git-send-email-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This list_del() for tc action is not needed actually, because we only use this list to chain bulk operations, therefore should not be carried for latter operations. Fixes: ec0595cc4495 ("net_sched: get rid of struct tcf_common") Cc: Jamal Hadi Salim Signed-off-by: Cong Wang --- net/sched/act_api.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/sched/act_api.c b/net/sched/act_api.c index cce6986..b4c7be3 100644 --- a/net/sched/act_api.c +++ b/net/sched/act_api.c @@ -64,7 +64,6 @@ int __tcf_hash_release(struct tc_action *p, bool bind, bool strict) if (p->tcfa_bindcnt <= 0 && p->tcfa_refcnt <= 0) { if (p->ops->cleanup) p->ops->cleanup(p, bind); - list_del(&p->list); tcf_hash_destroy(p->hinfo, p); ret = ACT_P_DELETED; }