From patchwork Sat Aug 6 10:48:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Khoronzhuk X-Patchwork-Id: 656415 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3s6Hjl0H0Cz9s9k for ; Sun, 7 Aug 2016 08:03:07 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b=N4hGNg1r; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751625AbcHFWDD (ORCPT ); Sat, 6 Aug 2016 18:03:03 -0400 Received: from mail-lf0-f41.google.com ([209.85.215.41]:36015 "EHLO mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751080AbcHFWDD (ORCPT ); Sat, 6 Aug 2016 18:03:03 -0400 Received: by mail-lf0-f41.google.com with SMTP id g62so224623296lfe.3 for ; Sat, 06 Aug 2016 15:03:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=wW/jNbF1ROHvGqyEq34mPcR+QzgRiTv3pDr4gnA+4iQ=; b=N4hGNg1rfoNlxdei90egzzdaBT96I+PcySWFdVtt5M05hrUpbG7l+uIPSjGpixG+l1 W2YtvECa5Gmtl3CYlzOBSBpt0r8f/XI/b5kSPoz4nzAbUd5e3uDlCTqLaPFzwvNqCiHx yzKdKJ2eZayslj1zXmRLoFionlV2y4iZ5AqX8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=wW/jNbF1ROHvGqyEq34mPcR+QzgRiTv3pDr4gnA+4iQ=; b=moZHhc2rEW/Q+5om3RvckpMFrY24Ux9vhB5ik5gRt9ijChQdJH+aYikdnaE8iU4A5B E9IIyyTnFbRI9VzG51JSEbJ27+5kQaPkeyjYrlzYKmGRbutvvL4CPohDqNFPc85GDkR0 eN3TeFvKL53O6AXVH0LGOzUtG77hzybdoJ5HWYxpWvEX8qTWaRZ72uFNZcz7eoyjGpco 6hujFSolC/diXRWdMGX8hmUjICEhJOOUKI3uweE2uy/jqbDHKBXImDRIQIKq3HHIPlZ2 gnUi0Xc9Q2u4ZnpKyBxJN8pmN6EeSL1JiE8l5ixw6cEKRTE/1iLnzFrCU7d8NniZLdHv J7VQ== X-Gm-Message-State: AEkoousD2q5FjkKr8m7RA8breV9SZ+Y0cta5oGbxBwevVv3Zumodiy9ZgEjQekMnaATbdoX9 X-Received: by 10.25.160.139 with SMTP id j133mr22188534lfe.227.1470480540504; Sat, 06 Aug 2016 03:49:00 -0700 (PDT) Received: from localhost.localdomain (153-224-132-95.pool.ukrtel.net. [95.132.224.153]) by smtp.gmail.com with ESMTPSA id p128sm3916360lfb.32.2016.08.06.03.48.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 06 Aug 2016 03:49:00 -0700 (PDT) From: Ivan Khoronzhuk To: netdev@vger.kernel.org, mugunthanvnm@ti.com, grygorii.strashko@ti.com Cc: linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org, dlide@ti.com, Ivan Khoronzhuk Subject: [PATCH v2 02/14] net: ethernet: ti: cpsw: remove redundant check in napi poll Date: Sat, 6 Aug 2016 13:48:32 +0300 Message-Id: <1470480524-6851-3-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1470480524-6851-1-git-send-email-ivan.khoronzhuk@linaro.org> References: <1470480524-6851-1-git-send-email-ivan.khoronzhuk@linaro.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org No need to check number of handled packets, when in most cases (> 99%) it's not 0. It can be 0 only in rare cases, even in this case it's not bad to print just 0. Signed-off-by: Ivan Khoronzhuk Reviewed-by: Mugunthan V N --- drivers/net/ethernet/ti/cpsw.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/ti/cpsw.c b/drivers/net/ethernet/ti/cpsw.c index 8972bf6..85ee9f5 100644 --- a/drivers/net/ethernet/ti/cpsw.c +++ b/drivers/net/ethernet/ti/cpsw.c @@ -793,9 +793,7 @@ static int cpsw_tx_poll(struct napi_struct *napi_tx, int budget) } } - if (num_tx) - cpsw_dbg(priv, intr, "poll %d tx pkts\n", num_tx); - + cpsw_dbg(priv, intr, "poll %d tx pkts\n", num_tx); return num_tx; } @@ -814,9 +812,7 @@ static int cpsw_rx_poll(struct napi_struct *napi_rx, int budget) } } - if (num_rx) - cpsw_dbg(priv, intr, "poll %d rx pkts\n", num_rx); - + cpsw_dbg(priv, intr, "poll %d rx pkts\n", num_rx); return num_rx; }