From patchwork Mon Aug 1 07:02:30 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Chen X-Patchwork-Id: 654544 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: davem@davemloft.net Delivered-To: davem-davemloft@shards.monkeyblade.net Received: from NAM01-BY2-obe.outbound.protection.outlook.com (mail-by2nam01on0073.outbound.protection.outlook.com [104.47.34.73]) by shards.monkeyblade.net (Postfix) with ESMTPS id BD685598F6C for ; Mon, 1 Aug 2016 00:11:41 -0700 (PDT) Received: from BN3PR0301CA0001.namprd03.prod.outlook.com (10.160.180.139) by BLUPR0301MB2051.namprd03.prod.outlook.com (10.164.22.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15; Mon, 1 Aug 2016 07:11:39 +0000 Received: from BY2FFO11FD029.protection.gbl (2a01:111:f400:7c0c::149) by BN3PR0301CA0001.outlook.office365.com (2a01:111:e400:4000::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.549.15 via Frontend Transport; Mon, 1 Aug 2016 07:11:39 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD029.mail.protection.outlook.com (10.1.14.212) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.549.5 via Frontend Transport; Mon, 1 Aug 2016 07:11:39 +0000 Received: from shlinux2.ap.freescale.net (shlinux2.ap.freescale.net [10.192.224.44]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u717BL1p013140; Mon, 1 Aug 2016 00:11:34 -0700 From: Peter Chen To: CC: , , , , , , , , , , , , , , , , , Peter Chen Subject: [PATCH v2 02/15] ethernet: apm: xgene: add missing of_node_put after calling of_parse_phandle Date: Mon, 1 Aug 2016 15:02:30 +0800 Message-ID: <1470034963-30506-3-git-send-email-peter.chen@nxp.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1470034963-30506-1-git-send-email-peter.chen@nxp.com> References: <1470034963-30506-1-git-send-email-peter.chen@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131145091000390889; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(2906002)(11100500001)(4326007)(68736007)(33646002)(86362001)(105606002)(7416002)(50226002)(189998001)(76176999)(50986999)(586003)(8936002)(47776003)(8676002)(19580405001)(229853001)(110136002)(81166006)(19580395003)(104016004)(2351001)(8666005)(356003)(87936001)(81156014)(85426001)(5003940100001)(69596002)(106466001)(97736004)(305945005)(48376002)(77096005)(36756003)(2950100001)(50466002)(92566002)(7846002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR0301MB2051; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD029; 1:xWg76ymBOpjNh0++hHcWPwK7foz9UuL+drf4L+4uHnr4iQArHGqE4WVldOPR0+nIBIkDxuD+u1wj1MCU+fXZq2po4IEq2LrTNNn9jFhdZ9pKcKo7E00t//U7V6WUreybxVD3no9UQ9H6gs0p/T9PUSjsQHz4+odImCDfCfDu5LRSR2aIHtiX8k242ICO98oMuZfZirAdrR/qMlMx26kI/lfYc9O478wR5VULYTwIM9uivVThUvlYIpxHecjrknfkDP2TJg1Ahzotq5PM6cgF0m6ktTpWjpz3k1Ri2c+80dHbzHwB2F2KNLXH0QNFGg5E3T1+/OK58BTVY52oK8X5ku340JUwMPh8inSSYHdQ6KlgjQ5g3E6zf6b2CQH8E5JIJXSLW9BzN6cPsnid65Je4IR1Ne120KZyg4Pp2mJHjyOVVYL7CfXS4wW2tNaxj2f407Kr+P1/qrgXO1nO9oOUWSB6llVeJsWrQj0UmOaL5sO9ckHZEL72OJpwlRWdBu2FF6r/+IkM7r1SOtv6bfjJIcXI/J4q1wtsSGiEhrX+K0Z3in6ONXCPZjBezvNvNvghdOXVDrvXudOAYDVWdL/nbtI0BGIbxoJTENvkTySawArkoYBMuhce8m/sUc5JtZ9oeqh6i+gbcfwZqgP3IgMw9z+Wo+VzahZQpKR3yzbTy8WoObb+bv12prTOqDRl1LyQAv1z4xj2cek/xwSLSBZruL/7eyhIPLfiGll94ZE2tg4= MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: f3ae2319-6796-4233-54e9-08d3b9db1594 X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB2051; 2:p5TlcLubeUawzkKHMQICDTvLwhOvKRLIWNZH4RKuMqnhTb2wKSvEOTtl/qPesyGzvkxEwBu7YDU2eKDwca02oLu6gehhxluEV0J+cdh6iHpP1MU3k87NKQrQ3Q1sF0aWUTWDbDJcBTz8wkvZ+Z9+y921YN9nzjcujDsww28eMDghOI4p3IfjSfK4ftBc7Sun; 3:AfpeQQ/4E7F+YeUUTf9NkO4KzGJGWKrhw8Ijx7TqXrI339EfkTmA0/Lt6zqKaydOq4mXsj+pJsgUpbumZmi/4oS3nwTtbLOKxe+cabBIUmdmMxV0zPZdEJqymYQ0z0rlul0JG2o3FHlfBW/NCnRp/1Gfz43oc3H+qnKC++S6dQ816vi9FX8CkpfNoY/o8TZVtBMhBGLOPSlUg5yzH5x/1aP9KSUow/KeEU09cCbrIs0=; 25:wUL+sAsF5Hgl+VkIvOlP5JyLPWDKcBGYPX2g0mcbv9cFEU7DVAq17aQZXHIGudTRoFL09v0275xxse9hZnMi3X+/0K/eDyoc2IKHkXJrEDzzAN51GGnyDV2aG2JfFv0RBfc2GFHMAQppB2knqpIb6lQ+43JzYhadqXdn8PuF0FtJKbZVXRcJlDxtN3w9oiAD842ytvWSbeDxBP71C4/DTN41kKB0//W32nlILCuMOi5C2TS+YNAqH3My/b9vr/sxTbFqT9qCdumn+sn+C7ZEu32I7/K0dTx1yxAImZvAcmMdaACnBVi4LO1GEc1Knsp7IqfsmV8OSeVUQ8DlHMVqEEnqmm1FUIuIdzU3BeXr/J7RNOzExZOiljnj4REmN5a+L4VTcrl23ixzUrwfdvqFtCyWWu5DZHkfIGSyrrUSuC4= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR0301MB2051; X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB2051; 31:PVl2037tDEKof/+990VNxNHoPtvN7eg7dNRxZR/Ks7QzYKu5IbpXUiUrhRNIMRuAhEbpbgIEmNGuLmMhb4BpT/WZnTRmy41Eq36ZhsVSmShTYFbD+Q4XwS09+6Uc1DUn9B0qUOpvCLDwikrm/C7DnRaJdBFzLQLX28etIaw7Q389Wn2LEzGqrv+PpUopESh7byZB4uFBWjdwwNg6mw5yPA==; 4:oLAJvqEs9OkNHN9+a8ZaSEOg8qtfB3lnT4ri+HGIJgVeRcWHBUZNrEgP34sbnNnVqfIqVYRgmhsI99KdtBqC6jJ3A1tQcZiO1aWHiqnyKW61DlEOVJWWhu3D9bqeTL8UFgqloWEP1+mn+EqZs9tiKYyB63+ZcrIm+eaqXR0/hR5ZqC1iNg0uDKAz2F2WxPVyZz4w5bSDE09YuuFsg0yHf+bvAATYyG9jRO/JQFtqQ2BC2nm4iKdJxsvqEpxyVpcBAhq0OTkSSd20ddzDWQOD0ad/ykdPkmuMLGIlZUC4l+t20va1+su2BWeKkDVUH8JPAoQoIjf3eGGaJOH86jFciQH7BQ7Ve8dErgfqfTq0+IV/hTJlm2wyLmRHOz64Em7yN0KtlXCVdvh8PS5vlOlimCUgJDsXUv+nhHnnuy9PeflShPATcgzbDYtxMo2voQfqwbuDE4rfjizqfcHry80rXuZQdH4HNEo1nhxr9tTBFUmMg9EWHnCajV/JtNeq51YmaRVdYnsxC9QcTvJpC6eq8dWx7vjdGq2FGHl+PFV6WdqV3iZfT8vop4Fko0lqi8cG X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(21532816269658); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13023025)(13024025)(13015025)(13018025)(13017025)(8121501046)(5005006)(10201501046)(3002001)(6055026); SRVR:BLUPR0301MB2051; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR0301MB2051; X-Forefront-PRVS: 0021920B5A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BLUPR0301MB2051; 23:1v1uWB/7JG7v1hukr08eydkYIaF0jevkWU8VBtz?= =?us-ascii?Q?dOHV9+qQCAm9l6v3yUQbYI91wa2COjkwS4xqG8V/6oRiaQ+ogfPFUujp3bKe?= =?us-ascii?Q?3MtSIJAyzq236s3qDPHCD9SZ1yC0+YZ0t7Ld/spNWolIFMSXVPexkUq8miKE?= =?us-ascii?Q?az93N1FYHXNYJ7RoI+M9hLYtnpRnE/GxvVJM6EkvX7BOO9gI+PF1ntrGBWhC?= =?us-ascii?Q?adKFsr7gUbw43LNG2WjGAZBxI3KJ0nmBvdMnTn6onBcM3rgH36U7vtrQQ9fx?= =?us-ascii?Q?jXEb6vpFev78Z8HMWOBjt4x8edowsQule132TRlKiCq9sOpRHeYqHjU5olLO?= =?us-ascii?Q?+SS1w0AdCKb7MNuO78rDunxFLd/hBUyqZfLwdcc3STaHwH0310MY0XY4rG5R?= =?us-ascii?Q?YklT4VjgO3AtMxTqAZQfqNXBTo2qD4je3fVWb52QiivtfPi0lWQoZAFzijyw?= =?us-ascii?Q?kwMhPyK/G2nos8GPuusrIZujrCMmImRt1pObC36MuFjNGyIHteUK24sBFp+o?= =?us-ascii?Q?U9wJWyIVKAQQlFfX7EuHXC9qGh++BgldwnWsjTj+VA1Rs9DfNkXDEzqvBfoy?= =?us-ascii?Q?OygY3AedZ5hu5WSUtDi72G5sxN6K3PCB8e5diT/Ga1Y3yCGLfwUahWXfSGpj?= =?us-ascii?Q?/DrFzEot1A/HHAkc5B8vWXlw8Ttv/0XkWDDP+TR096AKjRpNypAeib/Sv0v3?= =?us-ascii?Q?u4vtduBZj6+srMC2mg2m5qlIMRwmNhVdpSpdQk3Oe5uXN32vHT8t0yzrYjeY?= =?us-ascii?Q?9ItVfxM4bKMy1stu1VXIqIjuoylWah3ucV7WbQLSCtAA5o8DQAAyF2cL5Yn4?= =?us-ascii?Q?IFHVBUavQn7Hj7Yz7Jqpkz4w2fVQey/OiUBOyMYT+EyqnNPocKLTqj4tQrZk?= =?us-ascii?Q?ReW2qRSgiyiNgrkkuYC1skOMf6ryEsQijd9R/hTk5vq7frsiJOEE3VsC0ZnO?= =?us-ascii?Q?32p6a7RhVjNbdex+kh3AslBSOHbp+Yg3Q1+NDrUyT+LV+XSiydJMtbCiosjs?= =?us-ascii?Q?yyFlbzH4jx10qK3i7BTupkFE5ieiBcX3G9MdBUAyTd/Jx4QoZMuAwPik8blA?= =?us-ascii?Q?64kAhFH1dZZKRTIDVMsFDvYXBv0SW5wiPVf5H5iynifmaL9m6moe7g2GFl2o?= =?us-ascii?Q?w/XqGQSLFfedB+1Ewmx3IbgJry27U88cnNVOnjZNUhKIpqmjhpA+DBw=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR0301MB2051; 6:pKY5M8qeBrHooUNGvjOYUF7GCzVL8HN8RV354OU6f9zpj8+NbvMOaoYAD280SwGTXZshjgRHQAWJhJmn2N2EyViz5pMpOtxeyBOmV1PJhG8ZmF5PR55QP7fXab6xW0+DMmaNR6wlMy6N6+jmClbcXL9epoMZO/dmrYJdserhxtc56JodUZqf6wXrgYTA801RuRALuDfDYNMXzsG7wERMowD/7hk0u1hua+lVx85zteDJ1jN7Sb/4L2thPz6upmbse4sigpnb2gUXVKUae5XTihiqLRfHfgQH5H86tV6wAt8=; 5:7lwk5fnJRSPF1uFez6EzT99F7crAQ58HUHYjYU3/N6nDdEtDIl9VOeRNz2qkZn1pihjdJzndazNr6brkerNEJPKPrT6/7p+ToMA+oxr2+3Hnnb40zojEkHmojLRQ2wpQiLHTPaNFP8k87IKUT1LNFYkX1BgMhHpeywCkqJB8/Tg=; 24:ZWcxpsyu6z7CnKlRWJC4oLEgT+/e5nfvl6jNW1TEZsxztZ9pi4BymA/N1hsSW7onFqNArOth1iZP9uVGYaVnesV4MPbCoHl94GINUvZy4gI=; 7:mu1/tHxVhC5VZa8Bomhy0qLwAb6oVzSxo+fFP5Sbb0STJWgX2sGKQ9OoNhM0jqnMKksxe8yBZLZzmlN6UTSjFjMToqpyNIbtq2yrT/rWGGxfDZdGgSm0f0Qk8kxx/SCbVUqVdYeTqilrp0o8rIh9LK80eChAFuJjbQ7+o5MHMTLO1+piolu0j+z+Mbai9fCIu9NZpZq/K4riPaCBnIqwzbn5vXLeClO6uRaY/XjpUgKKSsKxSK1qotMwX2PqyZ3l SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Aug 2016 07:11:39.6958 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR0301MB2051 X-Greylist: Sender DNS name whitelisted, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 01 Aug 2016 00:11:41 -0700 (PDT) List-ID: of_node_put needs to be called when the device node which is got from of_parse_phandle has finished using. Signed-off-by: Peter Chen --- drivers/net/ethernet/apm/xgene/xgene_enet_hw.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c index 2f5638f..fb23408 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c @@ -758,6 +758,7 @@ static int xgene_enet_phy_connect(struct net_device *ndev) phy_dev = of_phy_connect(ndev, phy_np, &xgene_enet_adjust_link, 0, pdata->phy_mode); + of_node_put(phy_np); if (!phy_dev) { netdev_err(ndev, "Could not connect to PHY\n"); return -ENODEV;