From patchwork Sun Jul 31 07:42:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heinrich Schuchardt X-Patchwork-Id: 654312 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3s2Dwg62H3z9syB for ; Sun, 31 Jul 2016 17:43:31 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751349AbcGaHnM (ORCPT ); Sun, 31 Jul 2016 03:43:12 -0400 Received: from mout.gmx.net ([212.227.17.21]:56709 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750767AbcGaHnM (ORCPT ); Sun, 31 Jul 2016 03:43:12 -0400 Received: from LT002.fritz.box ([109.91.48.91]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0M2ojS-1bBXpN2K2A-00sdun; Sun, 31 Jul 2016 09:43:07 +0200 From: Heinrich Schuchardt To: Florian Fainelli Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Heinrich Schuchardt Subject: [PATCH 1/1] dsa: b53: remove redundant if Date: Sun, 31 Jul 2016 09:42:59 +0200 Message-Id: <1469950979-19506-1-git-send-email-xypron.glpk@gmx.de> X-Mailer: git-send-email 2.8.1 X-Provags-ID: V03:K0:yT21ANAQKchx8T1fohrpwlEv7/0J5+uylEAsYA1UD7IgI3Evl02 0RCFByrdtLJi8lQcGCTRvj1TJO9AXjc9nmc60HykJPF+cmeClseQPaSkWtEXyAkmsmuGqen SHmZE75c/9Nh8WW9RirLgE2uzHPrurQuLv0OmpvkCsc3r8VuWzPpQBiSskDFrGNmF4J0PLe 2hg7iRxY+IURuCx/iqhYw== X-UI-Out-Filterresults: notjunk:1; V01:K0:hrMbpYAkuwY=:9vOGEeKY/Lu9y1jT8Zggbz ujzHfGsNqypZ4q8Kh9bdnlOO7WR+WrPM4U3CZ52UH9sYojlCfgXjkjCI+NtK+H/da+zMH/61w OhqMc2FIApbTVUOyC1cgdASidM+N4VJfJ74k6Fv2r2VIpKIJINSY7ITd18h4c6gMVs334/16t duFRtjZzcbsMIEPJ8dRQm35e88MbWSa+xSAttXO6nBee++ESlSERzwd3nnAvhgSK2foLd3kqw aHebvXB8IqotEFu3CLNy1o4NEOf1OWmEDIzmyJvL0D/KbFXvG3WsoUyeuoGjoiFDa2iiF54wU wL14er4z30EbcyvP6By8eSMyBKTtWgi/WvS/+V/uT8uHGTozlCiGzMz7lf0LvScItyQTavtyy Tdv5bIS4C9nw59BpNyhUkOrGeVuXvNXy8cRwyz3tYHx+eE1dk7lh2uAJAqzbSAFsbMks4ixj2 pZLTjBxxnZ7uIwEODMOWoj7l7da7HfG8vDcFrxMzXLwfMZzMFMj+ySV8520NxY89bB0TheApA 0V8QBksz5DPdeOVfCYLxLnalqA3lC84jcDXqLDMCeRKysjBveYbnUtdGr9UDJOUT5t1qX7AKH 1snYlkeWNnIJ1fT46MdWeHMHhbzJZf+zneUzZN1jnPJvbjjJJO+1pEMtXrz7hUsv1Zh+9b0aY cJKX2s6w6TYuv2FrNTvQ1NSvTr/3Rph4tKBVtiCI/HEuzifd3yYKWJkt81zol6KGI/7T9Yjsp idr06aJ3CxC1ZyGmfkX7ByOuOu0aBUzxoEQze2DEOl/TshMA4KonD/mXo88= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org For pdata == null the code leaves with an error. There is need to check the condition again. Signed-off-by: Heinrich Schuchardt --- drivers/net/dsa/b53/b53_mmap.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/dsa/b53/b53_mmap.c b/drivers/net/dsa/b53/b53_mmap.c index 21f1068..77ffc43 100644 --- a/drivers/net/dsa/b53/b53_mmap.c +++ b/drivers/net/dsa/b53/b53_mmap.c @@ -233,8 +233,7 @@ static int b53_mmap_probe(struct platform_device *pdev) if (!dev) return -ENOMEM; - if (pdata) - dev->pdata = pdata; + dev->pdata = pdata; platform_set_drvdata(pdev, dev);