From patchwork Thu Jul 28 02:12:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 653523 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3s0FkG1fsQz9sBM for ; Thu, 28 Jul 2016 12:12:38 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=Bok/I4G3; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758875AbcG1CMe (ORCPT ); Wed, 27 Jul 2016 22:12:34 -0400 Received: from mail-pf0-f195.google.com ([209.85.192.195]:32780 "EHLO mail-pf0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754062AbcG1CMc (ORCPT ); Wed, 27 Jul 2016 22:12:32 -0400 Received: by mail-pf0-f195.google.com with SMTP id i6so2778978pfe.0 for ; Wed, 27 Jul 2016 19:12:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=euC/sHVJPKN2q2nBtrLm3JKVNwniWCn89/0Y7THtCmY=; b=Bok/I4G3TTkIqX7GRpsC2d/X3j85c4wnZ3j8ECOOmh+8IajoF+89cWY+PX6gdUrkJo 66SJvNt81TfUny+LY12w6gBNBRIRA3kOjlQOKULWy2+yBgVGY/zkvwNkF9UPD26h9/hM V9TLghWAFyK3hdm7GDHtvkKSYGTs0z+zm1uZoe2TyjLo+d0VOAyv2cdh3Y/+E6+gBDbv MXcrti1MUuKNtANwNS09YmUOZ0S0dMt48cWqisW8AE/hq/Ngit/t6sMMoJ5PPyfZSPrB PE4c1IkGZOVfH0cEU0H7DooLHxECChvaxcTkRa6Ro0G7VwZW65yUKYstnaYkvKP2sGxV hprw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=euC/sHVJPKN2q2nBtrLm3JKVNwniWCn89/0Y7THtCmY=; b=Thon44haL953VPyT4ncR384ySDkqLAUXPGyLylCU+FVYpCMlRIcbgdQdmqfk2GVHWK 5pI//vNj7h3KwHK5lxg6+HKiRsVyVNRPKi7DZVt+JW8PdiCi0ojJI2H28oW4S7dgzUJ4 eVnT4aUDaYYfNz83y2a4rJGkU+/jRd7f0d0yIqmH1WCfX/iFNypWf0v7Jf4tvhre1P9E DU+BnGGBDa3XhBo/H4PKg6oEVWNFe7RYnuC0dvW7HJyl96gR+Ida8+L35FjkVfYgOAkd 182y+53j9LNMSGKgPa2H5rzN+Xw/Tm+e4NqeVm4wN5M4BY8EPdPwvKQTgHGyP7/zusXu oOuA== X-Gm-Message-State: AEkooutNphn8aOtOlkFXlP3lYyl8rahbjbnATG+XMNEJAV/jEMzC7ELx8uCxqccfCfZqdw== X-Received: by 10.98.58.73 with SMTP id h70mr54474589pfa.125.1469671951659; Wed, 27 Jul 2016 19:12:31 -0700 (PDT) Received: from localhost.localdomain.localdomain (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id y200sm12185072pfb.13.2016.07.27.19.12.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Jul 2016 19:12:31 -0700 (PDT) From: Wei Yongjun To: Iyappan Subramanian , Keyur Chudgar , Florian Fainelli Cc: Wei Yongjun , netdev@vger.kernel.org Subject: [PATCH -next] drivers: net: phy: xgene: Remove redundant dev_err call in xgene_mdio_probe() Date: Thu, 28 Jul 2016 02:12:17 +0000 Message-Id: <1469671937-13265-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-TMASE-Version: CloudMessageScanner-0.0.0000-7.5.1021-22478.000 X-TMASE-Result: 10--4.977200-10.000000 X-TMASE-MatchedRID: 5sUo0NN0WF44tGBQPT0ZoUhEDfw/93Bu+uIuZYGsMgRUjspoiX02Fwku iFJsQqORZwJLsMg1MVIBtjkcfRMmqSnPugGsN3p55O5PclyYqqoLT2ejjmLR8Zsoi2XrUn/JyeM tMD9QOgDPl36UGZ40h8pH9EK2NKy+3QfwsVk0UbsIoUKaF27lxVqhZpAOMtFlX7L4uIhq67zryj b/AvFol3qoT2otfVo3wMib3j99VYbEmvzHierfTSWNqntji7NK/PCLCj/XMZ6ThxfBns9e3xMBe xWs+SIH3D94QFatAxc21XLFpkB2YKzp5y15pXcInqg/VrSZEiM= Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun Acked-By: Iyappan Subramanian --- drivers/net/phy/mdio-xgene.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/phy/mdio-xgene.c b/drivers/net/phy/mdio-xgene.c index d94a978..7756748 100644 --- a/drivers/net/phy/mdio-xgene.c +++ b/drivers/net/phy/mdio-xgene.c @@ -345,10 +345,8 @@ static int xgene_mdio_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); csr_base = devm_ioremap_resource(dev, res); - if (IS_ERR(csr_base)) { - dev_err(dev, "Unable to retrieve mac CSR region\n"); + if (IS_ERR(csr_base)) return PTR_ERR(csr_base); - } pdata->mac_csr_addr = csr_base; pdata->mdio_csr_addr = csr_base + BLOCK_XG_MDIO_CSR_OFFSET; pdata->diag_csr_addr = csr_base + BLOCK_DIAG_CSR_OFFSET;