diff mbox

[net-next] rxrpc: checking for IS_ERR() instead of NULL

Message ID 146850762158.24833.7534163896673339680.stgit@warthog.procyon.org.uk
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

David Howells July 14, 2016, 2:47 p.m. UTC 
From: Dan Carpenter <dan.carpenter@oracle.com>

The rxrpc_lookup_peer() function returns NULL on error, it never returns
error pointers.

Fixes: 8496af50eb38 ('rxrpc: Use RCU to access a peer's service connection tree')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David Howells <dhowells@redhat.com>
---

 net/rxrpc/conn_service.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Miller July 15, 2016, 9:16 p.m. UTC | #1 
From: David Howells <dhowells@redhat.com>
Date: Thu, 14 Jul 2016 15:47:01 +0100

> From: Dan Carpenter <dan.carpenter@oracle.com>
> 
> The rxrpc_lookup_peer() function returns NULL on error, it never returns
> error pointers.
> 
> Fixes: 8496af50eb38 ('rxrpc: Use RCU to access a peer's service connection tree')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: David Howells <dhowells@redhat.com>

Applied.
diff mbox

Patch

diff --git a/net/rxrpc/conn_service.c b/net/rxrpc/conn_service.c
index 7cbd612be0d7..fd9027ccba8f 100644
--- a/net/rxrpc/conn_service.c
+++ b/net/rxrpc/conn_service.c
@@ -163,7 +163,7 @@  struct rxrpc_connection *rxrpc_incoming_connection(struct rxrpc_local *local,
 
 	if (!peer) {
 		peer = rxrpc_lookup_peer(local, srx, GFP_NOIO);
-		if (IS_ERR(peer))
+		if (!peer)
 			goto enomem;
 	}