From patchwork Fri Jul 1 22:46:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Chan X-Patchwork-Id: 643305 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rhBNl3qQBz9ssP for ; Sat, 2 Jul 2016 08:46:47 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=broadcom.com header.i=@broadcom.com header.b=amt4ac/e; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752457AbcGAWqq (ORCPT ); Fri, 1 Jul 2016 18:46:46 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:32914 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752434AbcGAWqn (ORCPT ); Fri, 1 Jul 2016 18:46:43 -0400 Received: by mail-pf0-f175.google.com with SMTP id i123so43874438pfg.0 for ; Fri, 01 Jul 2016 15:46:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=MX4LDfkUHkt0bBLkHhvloUF36Icv1TVCMua7ffyKBww=; b=amt4ac/eFPtlKGr4doRZrVLRFPkm2psXQ7NkcbYHb/s8ZGi1/vx6sJmPbynHn6uYpE irmYrpVqo+0CF7ICYCqa71Y/KFwo3Bc+dpIXbiooqtcx+Fb4w/GN5dsH8eJayNZYOWGn LlxnHCzQk45w4hmXV59vageOJ8SFzo3a49vjA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=MX4LDfkUHkt0bBLkHhvloUF36Icv1TVCMua7ffyKBww=; b=J+FJ7N8y+x2t292H/uPM7iiuaPMoMVLzos2+m0evSKW9imJn50sD1LcrY4FIhRkWNr lTQ6bwS9CxmkHemOrT4SiQk8PjRRbJteLLNfW9+sk96XmNZFt9PWFYUFnQXiWc8WbXbV Ju2VjrMi5LWcP3OK+qfXpoAlvvC9koFbSyy5BrIevqQWKZC34K13kY6o06ssUbca+gdG 7VlNdkcXINy0KXHlXXy4BqAHJC+Gu8ELKqnTVLBFhLgZ70FSi5t+fk1G1BKyYqxFnCwb egeB/JYHCA8it1GXPaMvOHv8MpefVznID9jJGTpw7BpnF3rscyqwLLDPVeoN6g33xFMN fyjA== X-Gm-Message-State: ALyK8tJFPio95ltTwplYuka4HPM1DezvFkre6k13SLIgmiNQvqpKaI66sTWFkLWRT3sUYZLf X-Received: by 10.98.113.74 with SMTP id m71mr1105179pfc.6.1467413203028; Fri, 01 Jul 2016 15:46:43 -0700 (PDT) Received: from localhost.broadcom.com (5520-maca-inet1-outside.broadcom.com. [216.31.211.11]) by smtp.gmail.com with ESMTPSA id z29sm258541pff.0.2016.07.01.15.46.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Jul 2016 15:46:42 -0700 (PDT) From: Michael Chan To: davem@davemloft.net Cc: netdev@vger.kernel.org Subject: [PATCH net-next 01/11] bnxt_en: VF/NPAR should return -EOPNOTSUPP for unsupported ethtool ops. Date: Fri, 1 Jul 2016 18:46:19 -0400 Message-Id: <1467413189-29566-2-git-send-email-michael.chan@broadcom.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1467413189-29566-1-git-send-email-michael.chan@broadcom.com> References: <1467413189-29566-1-git-send-email-michael.chan@broadcom.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Returning 0 for doing nothing is confusing to the user. Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c index d7ab2d79..c63ed2f 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c @@ -961,7 +961,7 @@ static int bnxt_set_pauseparam(struct net_device *dev, struct bnxt_link_info *link_info = &bp->link_info; if (!BNXT_SINGLE_PF(bp)) - return rc; + return -EOPNOTSUPP; if (epause->autoneg) { if (!(link_info->autoneg & BNXT_AUTONEG_SPEED)) @@ -1483,7 +1483,7 @@ static int bnxt_set_eee(struct net_device *dev, struct ethtool_eee *edata) int rc = 0; if (!BNXT_SINGLE_PF(bp)) - return 0; + return -EOPNOTSUPP; if (!(bp->flags & BNXT_FLAG_EEE_CAP)) return -EOPNOTSUPP;