From patchwork Sun Jun 5 07:30:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Larry Finger X-Patchwork-Id: 630338 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3rMqJF01Wqz9t4Z for ; Sun, 5 Jun 2016 17:31:08 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=pyvrt+4z; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751054AbcFEHbG (ORCPT ); Sun, 5 Jun 2016 03:31:06 -0400 Received: from mail-oi0-f67.google.com ([209.85.218.67]:32927 "EHLO mail-oi0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750729AbcFEHbF (ORCPT ); Sun, 5 Jun 2016 03:31:05 -0400 Received: by mail-oi0-f67.google.com with SMTP id f12so5855284oig.0 for ; Sun, 05 Jun 2016 00:31:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=1XgfLcIhNNunySy7Zdet9Zcoa5Pule0qAsaGWWYyLr0=; b=pyvrt+4zPJfeIkKPQSzBDRx1uy8OTgZ8HWnu9gXwRUvnEpt3UOxoK4qUGZkVcwy1Du Cf677nlY/Jedb1WyP4ec6mIKRloSYn3XCAkgSlU27YFc4UHUJOoG8lLC/7vUiIvfLMaU UjGBj3+bi8dPjxChWYT1+WDv2cNNXenWJ3n5bDPXJzO46FcETj1i/8qTgXkmHPoPr789 lk7UmXCOhfH3jcdEHgmfSsKmKgeuCkKYFqhUBz8QA5Cw5//CrNSF3H3570oBskZrtRLK l+IRwC/fHsILblGuvGTr8kleYAyWEsMS8hmT2OC2awqp5JONir9Bmofuz6fZK6p+gv+E 2kwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=1XgfLcIhNNunySy7Zdet9Zcoa5Pule0qAsaGWWYyLr0=; b=f+qN9G/+wrp45soTcpGdo3G0yElTpilErlleRTBJ0Htpk7EzdqGUEC8pcFil5mNZLt W1tJwPeQsymYDkY7jHHLMzzxdoIQflHemhxUlyPrSDWAkoH5rBWlCc3l4/9SwCJ1XyyI zFpYRp3CXCbcYYaJSKLCInO/34L4PpCK3VBt3/WxbO8Vl3JQC4AODmBTvz+n43s0fLkG cFxIluaggK5+ci6uOhbt6fc1q/digNWh/3bjIjPX4OElgtYjVGcmFQEvy+9vcIAODLGY 96g1YLkfaVjaTxMkhdgCXw7eDxc7yQtVJeHzzsDEZUR56kBCOlqdHkHyAtAQYMY7RR4h OQBw== X-Gm-Message-State: ALyK8tJn/Wl/YpO5a9s/hj9IZEHXHmsMUpJMfj2e8O7SnGRhQUdXF3IGcrpfd0cncEm4Dg== X-Received: by 10.202.54.84 with SMTP id d81mr5969125oia.70.1465111863357; Sun, 05 Jun 2016 00:31:03 -0700 (PDT) Received: from linux.site (cpe-24-31-249-175.kc.res.rr.com. [24.31.249.175]) by smtp.gmail.com with ESMTPSA id 107sm7662273otc.24.2016.06.05.00.31.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 05 Jun 2016 00:31:02 -0700 (PDT) From: Larry Finger To: gregkh@linuxfoundation.org Cc: netdev@vger.kernel.org, devel@driverdev.osuosl.org, Larry Finger , Jacky Boen Subject: [PATCH] staging: r8188eu: Fix crash caused by commit 99aded71b52c Date: Sun, 5 Jun 2016 02:30:56 -0500 Message-Id: <1465111856-4398-1-git-send-email-Larry.Finger@lwfinger.net> X-Mailer: git-send-email 2.1.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Commit 99aded71b52cfdfa22721c42e42efdd13a02f0a6 ("Staging: drivers: rtl8188eu: use sizeof(*ptr) instead of sizeof(struct)") introduces an error in that the sizeof(struct hal_data_8188e) is 18712, while the sizeof(*adapt->HalData) is only 1! As a result, the system panics. Fixes: 99aded71b52cfdfa22721c42e42efdd13a02f0a6 ("Staging: drivers: rtl8188eu: use sizeof(*ptr) instead of sizeof(struct)") Signed-off-by: Larry Finger Cc: Jacky Boen --- drivers/staging/rtl8188eu/hal/usb_halinit.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/hal/usb_halinit.c b/drivers/staging/rtl8188eu/hal/usb_halinit.c index 87ea3b8..363f3a3 100644 --- a/drivers/staging/rtl8188eu/hal/usb_halinit.c +++ b/drivers/staging/rtl8188eu/hal/usb_halinit.c @@ -2072,7 +2072,8 @@ void rtl8188eu_set_hal_ops(struct adapter *adapt) { struct hal_ops *halfunc = &adapt->HalFunc; - adapt->HalData = kzalloc(sizeof(*adapt->HalData), GFP_KERNEL); + + adapt->HalData = kzalloc(sizeof(struct hal_data_8188e), GFP_KERNEL); if (!adapt->HalData) DBG_88E("cant not alloc memory for HAL DATA\n");