| Message ID | 1465066875-7089-1-git-send-email-colin.king@canonical.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
On Sat, Jun 4, 2016 at 4:01 PM, Colin King <colin.king@canonical.com> wrote: > From: Colin Ian King <colin.king@canonical.com> > > trivial fix to spelling mistake in pr_err message > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/net/ethernet/freescale/fec_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c > index 3c0255e..96bd210 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -2427,13 +2427,13 @@ fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec) > > cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr); > if (cycle > 0xFFFF) { > - pr_err("Rx coalesed usec exceeed hardware limiation"); > + pr_err("Rx coalesced usec exceeed hardware limiation"); > return -EINVAL; > } > > cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr); > if (cycle > 0xFFFF) { > - pr_err("Rx coalesed usec exceeed hardware limiation"); > + pr_err("Rx coalesced usec exceeed hardware limiation"); > return -EINVAL; > } > s/limiation/limitation
On Sat, 2016-06-04 at 16:43 -0300, Augusto Mecking Caringi wrote: > On Sat, Jun 4, 2016 at 4:01 PM, Colin King <colin.king@canonical.com> wrote: > > From: Colin Ian King <colin.king@canonical.com> > > trivial fix to spelling mistake in pr_err message [] > > diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c [] > > @@ -2427,13 +2427,13 @@ fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec) > > > > cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr); > > if (cycle > 0xFFFF) { > > - pr_err("Rx coalesed usec exceeed hardware limiation"); > > + pr_err("Rx coalesced usec exceeed hardware limiation"); > > return -EINVAL; > > } > > > > cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr); > > if (cycle > 0xFFFF) { > > - pr_err("Rx coalesed usec exceeed hardware limiation"); > > + pr_err("Rx coalesced usec exceeed hardware limiation"); > > return -EINVAL; > > } > > > s/limiation/limitation Could also add \n terminations to the pr_err uses.
From: Colin King <colin.king@canonical.com> Sent: Sunday, June 05, 2016 3:01 AM > To: Fugang Duan <fugang.duan@nxp.com>; netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Subject: [PATCH] net: fec: fix spelling mistake "coalesed" -> "coalesced" > > From: Colin Ian King <colin.king@canonical.com> > > trivial fix to spelling mistake in pr_err message > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/net/ethernet/freescale/fec_main.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/freescale/fec_main.c > b/drivers/net/ethernet/freescale/fec_main.c > index 3c0255e..96bd210 100644 > --- a/drivers/net/ethernet/freescale/fec_main.c > +++ b/drivers/net/ethernet/freescale/fec_main.c > @@ -2427,13 +2427,13 @@ fec_enet_set_coalesce(struct net_device *ndev, > struct ethtool_coalesce *ec) > > cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr); > if (cycle > 0xFFFF) { > - pr_err("Rx coalesed usec exceeed hardware limiation"); > + pr_err("Rx coalesced usec exceeed hardware limiation"); coalesed -> coalesced, Exceeed -> exceed, limitation-> limitation So: pr_err("Rx coalesced usec exceed hardware limitation \n"); > return -EINVAL; > } > > cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr); > if (cycle > 0xFFFF) { > - pr_err("Rx coalesed usec exceeed hardware limiation"); > + pr_err("Rx coalesced usec exceeed hardware limiation"); pr_err("Rx coalesced usec exceed hardware limitation \n"); Of course, pls add "\n" terminate char for all pr_err() in . fec_enet_set_coalesce() function. Thanks. > return -EINVAL; > } > > -- > 2.8.1
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 3c0255e..96bd210 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -2427,13 +2427,13 @@ fec_enet_set_coalesce(struct net_device *ndev, struct ethtool_coalesce *ec) cycle = fec_enet_us_to_itr_clock(ndev, fep->rx_time_itr); if (cycle > 0xFFFF) { - pr_err("Rx coalesed usec exceeed hardware limiation"); + pr_err("Rx coalesced usec exceeed hardware limiation"); return -EINVAL; } cycle = fec_enet_us_to_itr_clock(ndev, fep->tx_time_itr); if (cycle > 0xFFFF) { - pr_err("Rx coalesed usec exceeed hardware limiation"); + pr_err("Rx coalesced usec exceeed hardware limiation"); return -EINVAL; }