From patchwork Fri Apr 8 15:47:16 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 608067 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3qhP3c3KTCz9t5m for ; Sat, 9 Apr 2016 01:47:24 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=resnulli-us.20150623.gappssmtp.com header.i=@resnulli-us.20150623.gappssmtp.com header.b=I52eNosh; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758008AbcDHPrW (ORCPT ); Fri, 8 Apr 2016 11:47:22 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:36658 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753138AbcDHPrV (ORCPT ); Fri, 8 Apr 2016 11:47:21 -0400 Received: by mail-wm0-f65.google.com with SMTP id l6so5284048wml.3 for ; Fri, 08 Apr 2016 08:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id; bh=qDJenq0mdGD+kAK6ckJBCH9IuETH/JAcElicvNTn/is=; b=I52eNoshhAP7WkPXFJ5PQ+/mre1XH4pgSakywGzvNwaT22lCAMuP3pJ3cQK9abWz9m Er5ZalQioSAiuRBbtLfx2Hr+kYBpnjt+opwGQ9Ge00TkkNs+aSLHquqJky+oVO/wprPK 1H4jF/FqMgGxtSo2/nS47XEwVyE1ozSh9018wb0/cjHddfxK6szhyJP0y4UnvlGYZ7aZ ez+INw4jllh81oqjLJ6Iua2rVs4rbaNXvKD1BgqymXh7Ynp8bjta73dXwIATkMuD8Wtg XtyxAR3E3DJpeleY0f4RTyUEzJex6/wcpT0DdarCmrdNkGCFokKgzCu4m4Hwd8naWYP5 4BlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=qDJenq0mdGD+kAK6ckJBCH9IuETH/JAcElicvNTn/is=; b=X+t72Drb3nNxf/6BN7cVOlqO5V+hXbRpKJ3qR4yYcCinY7hN15MFyYoong9wqAh3gN Nht3LbFBSplzTn0i2kWwIApUlqMv5wPmbNB6SENzEEo82ykWUwTVo6nxj0MMXl7ThfPI IthzZCE0qVnWJXTVn5a9i4VjOqKS3pID8m6l8ZAjv+wOZ7b9ncv/WhZLpf6KcG/GaKfi B/8YuV0AUccYdNn5zr4GdLlxIYFy/4x68VwlPviq4KAmuhEKIymDhsKpBgDCKQ/h0qil Mv9o9FmZ64+Se6H/JXIVvvsZnKMIfpNsZI3W+g4CPdBIV9jksU69szTwXn1wm32DAvZ3 KXgw== X-Gm-Message-State: AD7BkJLehqeLzSNjg6ySo1wL0NQrIZG7+pjDNAYerszpYP0CBsFUO6uMAwWVo8Mb1QJs3Q== X-Received: by 10.194.248.135 with SMTP id ym7mr10320805wjc.174.1460130439822; Fri, 08 Apr 2016 08:47:19 -0700 (PDT) Received: from localhost (jirka.pirko.cz. [84.16.102.26]) by smtp.gmail.com with ESMTPSA id 188sm3651182wmk.6.2016.04.08.08.47.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Apr 2016 08:47:19 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, idosch@mellanox.com, eladr@mellanox.com, yotamg@mellanox.com, ogerlitz@mellanox.com, roopa@cumulusnetworks.com, gospo@cumulusnetworks.com Subject: [patch net-next 1/2] devlink: remove implicit type set in port register Date: Fri, 8 Apr 2016 17:47:16 +0200 Message-Id: <1460130437-15015-1-git-send-email-jiri@resnulli.us> X-Mailer: git-send-email 2.5.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko As we rely on caller zeroing or correctly set the struct before the call, this implicit type set is either no-op (DEVLINK_PORT_TYPE_NOTSET is 0) or it rewrites wanted value. So remove this. Signed-off-by: Jiri Pirko --- net/core/devlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/net/core/devlink.c b/net/core/devlink.c index 590fa56..44f880d 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -630,7 +630,6 @@ int devlink_port_register(struct devlink *devlink, } devlink_port->devlink = devlink; devlink_port->index = port_index; - devlink_port->type = DEVLINK_PORT_TYPE_NOTSET; devlink_port->registered = true; list_add_tail(&devlink_port->list, &devlink->port_list); mutex_unlock(&devlink_port_mutex);