From patchwork Mon Mar 14 22:40:00 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eric Dumazet X-Patchwork-Id: 597267 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3qPCPM3vc4z9sRB for ; Tue, 15 Mar 2016 09:40:07 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=XFFmPzZF; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753092AbcCNWkG (ORCPT ); Mon, 14 Mar 2016 18:40:06 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:35502 "EHLO mail-pf0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbcCNWkC (ORCPT ); Mon, 14 Mar 2016 18:40:02 -0400 Received: by mail-pf0-f175.google.com with SMTP id n5so107022519pfn.2 for ; Mon, 14 Mar 2016 15:40:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=Tfj7zmXWYR532fYEGTyVTBO7r9ljo4s6iKs76WcLLdM=; b=XFFmPzZFaolAcs9QQFBFZbGpw4v+0b0Uw2OmNJ0wVydSbFhkF1NGBLOCBJ5Bcj9Fkm XjTevZ4JFxfWPzk/pFxrktM8bpwXtpHdeVmlpGIeEkbklPSlO3lKHdEVCpU6io90Yls/ fkn4/5sfppTqlES7iX2S+nkQAB6+iGWOasocEU8AeheU3AixBcr08Yba6lIP81+YolZn 8apupAxEDFUUhFj09PL5FRuTwoULs/0P9BpsNtEnUzAnzO4ftRZ8g3DWkfAdgNiw+nhq fMdn5mnBaJnKP9rvfq9OpfRzDdSzMAwtgLL3vQD2JP2LNA/1x6NKQJubj1RqWaLMKs+Q Ze6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:subject:from:to:cc:date:mime-version :content-transfer-encoding; bh=Tfj7zmXWYR532fYEGTyVTBO7r9ljo4s6iKs76WcLLdM=; b=PKFaZBp/7P9Aqf6dikEhypO/3SOuExWf3NMlD/a2wbbq3LA23ywVNjAxXMtpNh8fXj wkKbGQ7nC10e8VkG4fpPKPwYADwPv5qZ8uubqEKy8prmO8J2pJcrGAOp2ns2pXFkilft pgDdUBtGFN1feTbNIpnsnQvXRq+PyXIAR9wpt84LfkZyOz+3Zekuqut71mKfbSZ5Q/A5 JE9QO5jBTUGfet/W8E2/4+QzTvlpMYPsKEWccqAGoC1SlEt3QwILmZ3gv72rG12ZEdaf iImk4EmKEYF+doQs9/lYCPAcixEPQuo7FC98JUHCCs+/5O1Bz4VDkZJwYIgyXmAfjCNb XC7Q== X-Gm-Message-State: AD7BkJK6oAyoJWQ4noKwCFyjeytRRBvvYHhG1hCi8xQtx9dQZ25C1hEzICseVpTfvVFV4w== X-Received: by 10.98.72.8 with SMTP id v8mr23266833pfa.33.1457995201616; Mon, 14 Mar 2016 15:40:01 -0700 (PDT) Received: from ?IPv6:2620:0:1000:1704:69db:4483:17c9:29a9? ([2620:0:1000:1704:69db:4483:17c9:29a9]) by smtp.googlemail.com with ESMTPSA id m10sm34492652pfi.32.2016.03.14.15.40.00 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 14 Mar 2016 15:40:01 -0700 (PDT) Message-ID: <1457995200.31401.28.camel@edumazet-glaptop3.roam.corp.google.com> Subject: [PATCH net] net: diag: add a scheduling point in inet_diag_dump_icsk() From: Eric Dumazet To: "David S. Miller" Cc: netdev@vger.kernel.org Date: Mon, 14 Mar 2016 15:40:00 -0700 X-Mailer: Evolution 3.10.4-0ubuntu2 Mime-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Eric Dumazet On loaded TCP servers, looking at millions of sockets can hold cpu for many seconds, if the lookup condition is very narrow. (eg : ss dst 1.2.3.4 ) Better add a cond_resched() to allow other processes to access the cpu. Signed-off-by: Eric Dumazet --- net/ipv4/inet_diag.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/inet_diag.c b/net/ipv4/inet_diag.c index 6029157..7883473 100644 --- a/net/ipv4/inet_diag.c +++ b/net/ipv4/inet_diag.c @@ -879,6 +879,7 @@ next_normal: } spin_unlock_bh(lock); + cond_resched(); } done: