From patchwork Tue Mar 1 09:27:35 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang Shengju X-Patchwork-Id: 590428 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 9D93614029E for ; Tue, 1 Mar 2016 20:26:52 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752737AbcCAJ0g (ORCPT ); Tue, 1 Mar 2016 04:26:36 -0500 Received: from cmccmta2.chinamobile.com ([221.176.66.80]:2409 "EHLO cmccmta2.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750913AbcCAJ0e (ORCPT ); Tue, 1 Mar 2016 04:26:34 -0500 Received: from spf.mail.chinamobile.com (unknown[172.16.121.3]) by rmmx-syy-dmz-app08-12008 (RichMail) with SMTP id 2ee856d56044571-e5658; Tue, 01 Mar 2016 17:26:28 +0800 (CST) X-RM-TRANSID: 2ee856d56044571-e5658 X-RM-SPAM-FLAG: 00000000 Received: from zhangshenju.host.bclinux.novalocal.openstacklocal (unknown[223.105.0.130]) by rmsmtp-syy-appsvr02-12002 (RichMail) with SMTP id 2ee256d56040664-3c371; Tue, 01 Mar 2016 17:26:28 +0800 (CST) X-RM-TRANSID: 2ee256d56040664-3c371 From: Zhang Shengju To: davem@davemloft.net, kvalo@codeaurora.org, johannes@sipsolutions.net, netdev@vger.kernel.org Subject: [net-next 1/4] vxlan: use reset to set header pointers Date: Tue, 1 Mar 2016 09:27:35 +0000 Message-Id: <1456824458-19499-2-git-send-email-zhangshengju@cmss.chinamobile.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1456824458-19499-1-git-send-email-zhangshengju@cmss.chinamobile.com> References: <1456824458-19499-1-git-send-email-zhangshengju@cmss.chinamobile.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Since offset is zeor, it's not necessary to use set function. Reset function is straightforward, and will remove the unnecessary add operation in set function. Signed-off-by: Zhang Shengju --- drivers/net/vxlan.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c index 775ddb4..8ca243d 100644 --- a/drivers/net/vxlan.c +++ b/drivers/net/vxlan.c @@ -1460,7 +1460,7 @@ static struct sk_buff *vxlan_na_create(struct sk_buff *request, reply->dev = dev; skb_reserve(reply, LL_RESERVED_SPACE(request->dev)); skb_push(reply, sizeof(struct ethhdr)); - skb_set_mac_header(reply, 0); + skb_reset_mac_header(reply); ns = (struct nd_msg *)skb_transport_header(request); @@ -1480,7 +1480,7 @@ static struct sk_buff *vxlan_na_create(struct sk_buff *request, reply->protocol = htons(ETH_P_IPV6); skb_pull(reply, sizeof(struct ethhdr)); - skb_set_network_header(reply, 0); + skb_reset_network_header(reply); skb_put(reply, sizeof(struct ipv6hdr)); /* IPv6 header */ @@ -1495,7 +1495,7 @@ static struct sk_buff *vxlan_na_create(struct sk_buff *request, pip6->saddr = *(struct in6_addr *)n->primary_key; skb_pull(reply, sizeof(struct ipv6hdr)); - skb_set_transport_header(reply, 0); + skb_reset_transport_header(reply); na = (struct nd_msg *)skb_put(reply, sizeof(*na) + na_olen);