From patchwork Sun Feb 28 21:59:53 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Igal.Liberman" X-Patchwork-Id: 590004 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 72105140BCD for ; Tue, 1 Mar 2016 02:17:32 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755389AbcB2PR1 (ORCPT ); Mon, 29 Feb 2016 10:17:27 -0500 Received: from mail-bn1bon0130.outbound.protection.outlook.com ([157.56.111.130]:17591 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751457AbcB2PRZ (ORCPT ); Mon, 29 Feb 2016 10:17:25 -0500 Received: from DM2PR03CA0006.namprd03.prod.outlook.com (10.141.96.16) by DM2PR03MB511.namprd03.prod.outlook.com (10.141.87.19) with Microsoft SMTP Server (TLS) id 15.1.409.15; Mon, 29 Feb 2016 15:17:18 +0000 Received: from BL2FFO11FD036.protection.gbl (2a01:111:f400:7c09::167) by DM2PR03CA0006.outlook.office365.com (2a01:111:e400:2428::16) with Microsoft SMTP Server (TLS) id 15.1.415.20 via Frontend Transport; Mon, 29 Feb 2016 15:17:17 +0000 Authentication-Results: spf=neutral (sender IP is 192.88.158.2) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; freescale.mail.onmicrosoft.com; dmarc=none action=none header.from=freescale.com; Received-SPF: Neutral (protection.outlook.com: 192.88.158.2 is neither permitted nor denied by domain of freescale.com) Received: from az84smr01.freescale.net (192.88.158.2) by BL2FFO11FD036.mail.protection.outlook.com (10.173.161.132) with Microsoft SMTP Server (TLS) id 15.1.422.5 via Frontend Transport; Mon, 29 Feb 2016 15:17:16 +0000 Received: from b31950-Sun-Ultra-20-Workstation.fil.ea.freescale.net ([10.96.120.74]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u1TFHEnn011841; Mon, 29 Feb 2016 08:17:14 -0700 From: To: CC: , , Igal Liberman Subject: [PATCH] fsl/fman: Initialize fman->dev earlier Date: Sun, 28 Feb 2016 23:59:53 +0200 Message-ID: <1456696793-32417-1-git-send-email-igal.liberman@freescale.com> X-Mailer: git-send-email 1.7.9.5 Reply-To: X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CPI:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(2980300002)(3190300001)(199003)(189002)(50466002)(87936001)(53806999)(50986999)(4326007)(5003940100001)(6806005)(107886002)(5001960100002)(105586002)(110136002)(36756003)(586003)(5008740100001)(189998001)(1220700001)(1096002)(4001430100002)(47776003)(104016004)(48376002)(33646002)(229853001)(43066003)(50226001)(2351001)(450100001)(2876002)(86152002)(3450700001)(86362001)(106466001)(77096005)(19580395003)(19580405001)(2906002)(4720700001); DIR:OUT; SFP:1102; SCL:1; SRVR:DM2PR03MB511; H:az84smr01.freescale.net; FPR:; SPF:Neutral; MLV:sfv; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11FD036; 1:TU+wNcl4mlV1RYb/E8apSZLx/b+rJ4uYhgUKFZ2SSMSras9THdPdbGP/tk0e1JVQOQD3fjItAGPEEJIwQ+zwImJwNAkzYjXpomwbj5pVmdee4IsxRP6YD/gSaYprHnp7Gwbd4dJ9TspKie0NPxVMJUD8AGw+EzcZkKR8bJWPY4Zgwy9TwAR29J1OgAG9LMOAeYfd37JtGrPRaAakXNYXf5UfNjfv5wUfZzuyAnZHwLOVE/BhKlch3SoaGuJCe8YSVc0ACVcNWMaAnywuCTVZFSf0bVJywpBwD3hAW6lCxpwFTcqwi1uGyRSYCZOEHmcZPnxcf9M8dnU8gik6QeAfFlu9/0MPoSOK1Kbbidi0QeCOBYd1S8Cgzjc6UHqEPu2aBH0p9UPN6VZhhbMLj0joQvrQUc/wvpKrrU3w71Ego5NVWWf3r9hmP/yUiQ13grqsC/UeXEYgvZiQDWoHQhGm/fGIQ/Uwvsto6XVNtISqxw3qYM4O8JK9gF8YUZo0PiotA+gAJutrxLxjcQMpUHB4gg== MIME-Version: 1.0 X-MS-Office365-Filtering-Correlation-Id: cc2de32b-90b0-42f4-6f47-08d3411b68a8 X-Microsoft-Exchange-Diagnostics: 1; DM2PR03MB511; 2:pP/OR2IWkzfhW+2nuDXpogCd6Zq1LLum4+nmmMn6aN8o5qt2d9KD5L7w8ElVaOQsXNHwd2PGuo5UH/yxph5BYTtWIkUXBmAFL1dYYERQkcSEsEW75h3y/xGfVHqLVuEG8FFlsTe3Bsz3bz8HmCZ45vZHkNk0wqUrsKDhOuA9VwCwKHocLqFM05wh1f+/IqcN; 3:uMt1TpM8Ys5owpm+4t9/B3+sUdvFHNi3HQOWYwUpky6YQ2u1pelx1C0JBis+Ft7blP12bGRmt3Dp9ReHENj7K2AP2G3yjYeCAFUZWcHP9kB0BYheVtx1JGBdY4Zstiur3qfr5Xy5Sc19/c7jYJovI3Bgudb9YkzhuFzmS4bdBLRHAJpsngkPoY6tmO/cER0c; 25:c5h11v/jwsgClsV0OaamAK7ErDBBaOLO+coifNuvAz8j27hZ8Ba+htGDj5r9+Q3SkLiC4IVuw7J6cPpr5ar99k938MNkt68Teh6oYMCe590S/PvuswrOUif3W0eaHv7KfUgSwfxKhtHBXtTwG1KFt+JbhQLCLUCThJZJWIsfYt5qZ9LDp26IlEl3KnHUvADY501GkeI/Q2bHTbxCsIjqe1FPd/ommclEiWETtQCYxTfmHq/lS/pb1S6wfVEPIHvTbNXx9G5AgKSHLEQjTbqEa1Vatdo2TJFaB9Li/csQOUVvN9EENjdqscxEyBil9CdaZd7aGv8wgNgWxRBZuxk5ow== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB511; X-Microsoft-Exchange-Diagnostics: 1; DM2PR03MB511; 20:Xy0SRnzAflV8QhRNqxttOfTtAdv6omTCSE49xAiPg6oP2XtIT7ywkRq6l7ivcVLkBV+SRZyHFm8t48921zDcs4Cuxnmm9Dn82Q++84N2xwps4vsJhMqR8KX/rFQHKS2M7agW4mb8AGE+HKbsj5zJqtCb7WelEz25+sSCzbfxN8GoXj+GXNoaYGjAPXnUoHb8ptRytDdxPl767qGsQhKQh7nPUMVwADA9wv/ZZ89zHvZnt4ZvygWGewPM1cjGjVi0Q7GDq7PJWVb4KQkBiL7Ckye59fmYRzzcVTPvE8WCNg09z7GvoKe79o2Qr83fDhjM5bx72afOIlq7lrg6brc8Ct1J/R5rO6h9YMThAXf0NPT9WLeVawE+zjriV4/XB6c98cY+L9oFc9wWcT/bfgvmOmAhm65MQ2Mlv9ieyMi9RvJdhEPCKqzTR+1NQFcBTdTH; 4:/pxU+hjXItZR1ipblkObo2PktieH6VkjoKJX6ULTL8M+LdGEeI3l42DYFwpNnBS2XW4d61xYeLlIYMUc2QdIKluqgmGEH+OJydw1OHkSW0xJwy517NFlRNwaZgJDkKYQEbjJ1YgIljHkwVUkg9gs+Yu7yOq/0o5GtbDIniMtc7ydlh9ZyQnR8y9Zby9ytWJAWUUdlA+EC/NeSLKIXL9wjow8CX0A/0l0s2xG9LxrhqFA9kcwXGqlECJKwrpdf6GLOwLkew8bP4gbFnaDnHN5CEGikR2veYlUvlq/+F8h0j+eWmizHjCdeq8oAzBDttRJfK9Y0+CIrP5WQligFKp8Fpv0pNtNnHUXJpB3RXw5K9IxYCHT2ZVZybBel9J5oJQTK2xl4NAFdtzDGV3/0Q7M4TW4Hwzhlh0TUejlcWXeQY3tDMeNAC2kn8GNkvvCUymGuSz+91qwhuJW0O/WjcsZ5g== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(13023025)(5005006)(13017025)(13015025)(13024025)(13018025)(8121501046)(3002001)(10201501046); SRVR:DM2PR03MB511; BCL:0; PCL:0; RULEID:; SRVR:DM2PR03MB511; X-Forefront-PRVS: 0867F4F1AA X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DM2PR03MB511; 23:anjv+1IMqfccybUpAH+qXyWfJVxGYSn8xjXiTbaOGW?= =?us-ascii?Q?OtuyOBYoaXNzkTg3BaQJLzbcBLKmHKWVuZlQxnX2/NmzaJnA/mkjuQC4kd60?= =?us-ascii?Q?uBefuqzW0+o2s2iKNfO5lS4uBOdWYsPls+nXE+gCrkB2X3/NHtKC8dKu34oj?= =?us-ascii?Q?kNICk1kNQ5q0lYOp1T8ToVIkZ/7Lt9I0OILz9tQms1AHN7TJH8TtkFfkUhL7?= =?us-ascii?Q?9+ifOPDVYOiv3yFBV68yaCERwBUmALMHAf1LhQnFrGiO56zpWZpbDb158gbz?= =?us-ascii?Q?pnPJYQsveWiW3tVs1u7eCX8td/c1af8Z+oWBI2tpWutGdAQ8LMdAqS07XELh?= =?us-ascii?Q?HLeV2kFxvffEIav+R98Kbuh5FGeylngWX/j4Xu+JQkR9V094A02t2B8X8Ya1?= =?us-ascii?Q?lJ9UqGhvlciwt+tFlmhgqcQmO6HuAAQkPWO1tGf8Hjk2cPbxjRK7LebPk2Zg?= =?us-ascii?Q?0OdcbcLB58ofXdDM4q9fR+GnUaDq6KNii3acPknJBF+iOUISVNNvJ+X3uOSE?= =?us-ascii?Q?MGmIt6hrFuXbaSNsj43cxEMJ+IrprxdLIe5d+xkIqwXT39/TnHV8PLOo0HoQ?= =?us-ascii?Q?E7qA6vXvY9BgfFrkL1/XPPG1FRXhqR/gy/rS2UDrbpVbQnzk8/J6Mt+H/s6Y?= =?us-ascii?Q?ngWYCk5Do2+dNsoYTqdXTVQemPysiyePsMW1d/FDgCqNP3FABuWCAI9a9KQR?= =?us-ascii?Q?AlzhYfQKNzC4Kp4WoEYa7cOKBMZYK0/rpJ6vmQYUhyRjVJuGZQXR3mmA/U1H?= =?us-ascii?Q?JgRTDahqSYvmerY/82kMP7wQ8lc5KShiUzTAQdlpOddm/zUFzzyWuGiFh2MS?= =?us-ascii?Q?3u69FmWJQVa3jKl1OCFA5xN6wlZ2sqfgJC48kZw7uQBBTx9qO0E3ZuRGdSkr?= =?us-ascii?Q?SivzvxbOO9X2crMACTVLmlvv0S5FcQ94zaT6Hi5GrwTSP5YDvbJo2gtcEkyW?= =?us-ascii?Q?q2FqPyKa7BC3XdLCbMefCHK5LICW+HBNkRFiYX1AwTlcwHTXUIkSGNqHSCTc?= =?us-ascii?Q?TmqLipYXiDCfy3scLpgtoj7MjMwtKtVB+SXg35yA4aGB2fcfWaHbux98ofsk?= =?us-ascii?Q?/xnljTGUmrCwFxYMeOyRO0HPSE0SWQQ0g/PzrHhk+chO1S34sKT1T4NU4L6u?= =?us-ascii?Q?d28O6xGik=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM2PR03MB511; 5:57hM72YC3CERCEUT4ddrEQlhoo4E6Ho4dX0umclK7Hh/sXdY+yNVpw1mdcMp4rBj3Uxqfzy7HUivxYe4Xz3BTJi60hi7CIMoTvh8YgwMWuczrgFgZ1fTPwEkm/EE4Q9DnHzwxdTFY95OjCYYL2GaiQ==; 24:gPidpheVAN0xwtQTbl7ziymuVvAg3NNrS/PU9tqlG1wYnRElOwcRnpPCwVUhm4zhYU4O+lASL7FB73AyWw7oi5OxMqheP6Ep+82VHJOJS5E= X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2016 15:17:16.2823 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR03MB511 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Igal Liberman Currently, in a case of error, dev_err is using fman->dev before its initialization and "(NULL device *)" is printed. This patch fixes this issue. Signed-off-by: Igal Liberman --- drivers/net/ethernet/freescale/fman/fman.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/freescale/fman/fman.c b/drivers/net/ethernet/freescale/fman/fman.c index 623aa1c..79a210a 100644 --- a/drivers/net/ethernet/freescale/fman/fman.c +++ b/drivers/net/ethernet/freescale/fman/fman.c @@ -2791,6 +2791,8 @@ static struct fman *read_dts_node(struct platform_device *of_dev) goto fman_free; } + fman->dev = &of_dev->dev; + return fman; fman_node_put: @@ -2845,8 +2847,6 @@ static int fman_probe(struct platform_device *of_dev) dev_set_drvdata(dev, fman); - fman->dev = dev; - dev_dbg(dev, "FMan%d probed\n", fman->dts_params.id); return 0;