From patchwork Wed Feb 24 04:26:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kirsher, Jeffrey T" X-Patchwork-Id: 587189 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id AFC2E140317 for ; Wed, 24 Feb 2016 15:27:23 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932625AbcBXE1T (ORCPT ); Tue, 23 Feb 2016 23:27:19 -0500 Received: from mga02.intel.com ([134.134.136.20]:51525 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757400AbcBXE0b (ORCPT ); Tue, 23 Feb 2016 23:26:31 -0500 Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP; 23 Feb 2016 20:26:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.22,492,1449561600"; d="scan'208";a="922634926" Received: from jtkirshe-linux.jf.intel.com ([134.134.3.161]) by fmsmga002.fm.intel.com with ESMTP; 23 Feb 2016 20:26:27 -0800 From: Jeff Kirsher To: davem@davemloft.net Cc: Julia Lawall , netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com, jogreene@redhat.com, Gangfeng Huang , Fengguang Wu , Jeff Kirsher Subject: [net-next 08/20] igb: fix compare_const_fl.cocci warnings Date: Tue, 23 Feb 2016 20:26:12 -0800 Message-Id: <1456287984-10459-9-git-send-email-jeffrey.t.kirsher@intel.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1456287984-10459-1-git-send-email-jeffrey.t.kirsher@intel.com> References: <1456287984-10459-1-git-send-email-jeffrey.t.kirsher@intel.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Julia Lawall Kernel code typically uses == NULL. Generated by: scripts/coccinelle/misc/compare_const_fl.cocci CC: Gangfeng Huang Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu Tested-by: Aaron Brown Signed-off-by: Jeff Kirsher --- drivers/net/ethernet/intel/igb/igb_cdev.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_cdev.c b/drivers/net/ethernet/intel/igb/igb_cdev.c index df237c6..28fafec 100644 --- a/drivers/net/ethernet/intel/igb/igb_cdev.c +++ b/drivers/net/ethernet/intel/igb/igb_cdev.c @@ -92,7 +92,7 @@ static int igb_bind(struct file *file, void __user *argp) adapter = (struct igb_adapter *)file->private_data; - if (NULL == adapter) + if (adapter == NULL) return -ENOENT; mmap_size = pci_resource_len(adapter->pdev, 0); @@ -119,7 +119,7 @@ static long igb_mapring(struct file *file, void __user *arg) return -EINVAL; adapter = file->private_data; - if (NULL == adapter) { + if (adapter == NULL) { dev_err(&adapter->pdev->dev, "map to unbound device!\n"); return -ENOENT; } @@ -182,7 +182,7 @@ static long igb_mapbuf(struct file *file, void __user *arg) return -EINVAL; adapter = file->private_data; - if (NULL == adapter) { + if (adapter == NULL) { dev_err(&adapter->pdev->dev, "map to unbound device!\n"); return -ENOENT; } @@ -246,7 +246,7 @@ static long igb_unmapring(struct file *file, void __user *arg) return -EINVAL; adapter = file->private_data; - if (NULL == adapter) { + if (adapter == NULL) { dev_err(&adapter->pdev->dev, "map to unbound device!\n"); return -ENOENT; } @@ -310,7 +310,7 @@ static long igb_unmapbuf(struct file *file, void __user *arg) return -EFAULT; adapter = file->private_data; - if (NULL == adapter) { + if (adapter == NULL) { dev_err(&adapter->pdev->dev, "map to unbound device!\n"); return -ENOENT; } @@ -398,7 +398,7 @@ static int igb_close_file(struct inode *inode, struct file *file) { struct igb_adapter *adapter = file->private_data; - if (NULL == adapter) + if (adapter == NULL) return 0; mutex_lock(&adapter->cdev_mutex); @@ -434,7 +434,7 @@ static int igb_mmap(struct file *file, struct vm_area_struct *vma) dma_addr_t pgoff = vma->vm_pgoff; dma_addr_t physaddr; - if (NULL == adapter) + if (adapter == NULL) return -ENODEV; if (pgoff == 0)