From patchwork Wed Feb 3 11:45:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 577861 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 5BB1314033E for ; Wed, 3 Feb 2016 22:47:28 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b=PS/hEp+b; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757000AbcBCLrV (ORCPT ); Wed, 3 Feb 2016 06:47:21 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:35928 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932636AbcBCLph (ORCPT ); Wed, 3 Feb 2016 06:45:37 -0500 Received: by mail-wm0-f50.google.com with SMTP id p63so160975464wmp.1 for ; Wed, 03 Feb 2016 03:45:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=qLVX9I4i7MRtzIMtrsMfQudZkxWF8KQRb/EtsH3LeAY=; b=PS/hEp+bRdu5ayGZbmhOMMa3ZbWqJRDzZYc/jHMpAAqAV+9F9vpxzwLEqBANUoXQhI V9x5fHgto2dlUuR3u3UgFwbbF/ZlkJ9plDmkqJuJHm6vPpdbqgpnajsnLhhX0gWJPC8u ntyG0rFEM+chHH2H/UOXPyEPWjZ4D4jnhWUp7AownBi1+BMoMvXBckcNzb/PKxBuwo33 AtI0TzBK1yF0qnO3glOQdaafEMJaLjmo8nWb7Ihp6Ir/M34vx0YAwfLgYTRh7dlwW0kq AMvhCBk01VscXoQBSCE9XY5I8X8pjsYDEYOE9vTdvJBoepfotmajC2jUh0xx4msvZZ1A aAHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=qLVX9I4i7MRtzIMtrsMfQudZkxWF8KQRb/EtsH3LeAY=; b=IHWRLji988iZGcv1o/RF7pkM/PX8XFegYZjRbzpcvwivsCkIO8W2kS3lxNQnyrnS+m vGmCscCIRv5QwvNRRzrLu2TUzoZcf2aNp2Mec7tD9BQWjBAAkpp8PDRUARDoRd7W+Ny9 wYP9Dj6FNxnoi6QLpqMnCAklhjNl0yDrvLEv796hayklmQ9KLHA0jx/H0kxXP+VqUyPm OUologF+csC4+zEf1uz7rhsf9YcsPNb0+WV8owF4VFbij8RDks3rbYQ7qLsivF0sxkUF F6ql+WUhvfQgNJe3LcIrdREAOA5a8/HjK8lGxPI+2vaglUru43+eg0D5KdVv2UdlkP1A sLTg== X-Gm-Message-State: AG10YOROjo2AEdKVTuUDsWMJCYxKAdGhQGL/R8ua8/JrkYmFetCQrzuKTvrClmGY/wwmDnkG X-Received: by 10.194.243.10 with SMTP id wu10mr1382667wjc.14.1454499936528; Wed, 03 Feb 2016 03:45:36 -0800 (PST) Received: from jkicinski-Precision-T1700.netronome.com (host217-39-174-19.in-addr.btopenworld.com. [217.39.174.19]) by smtp.gmail.com with ESMTPSA id gb9sm6084421wjb.26.2016.02.03.03.45.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 03 Feb 2016 03:45:35 -0800 (PST) From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, Jakub Kicinski Subject: [RFC (v3) 01/19] nfp: return error if MTU change fails Date: Wed, 3 Feb 2016 11:45:07 +0000 Message-Id: <1454499925-16359-2-git-send-email-jakub.kicinski@netronome.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1454499925-16359-1-git-send-email-jakub.kicinski@netronome.com> References: <1454499925-16359-1-git-send-email-jakub.kicinski@netronome.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org When reopening device fails after MTU change, let the userspace know. MTU remains changed even though error is returned, this is what all ethernet devices are doing. Signed-off-by: Jakub Kicinski Reviewed-by: Rolf Neugebauer --- drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c index 43c618bafdb6..006d9600240f 100644 --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c @@ -1911,6 +1911,7 @@ static void nfp_net_set_rx_mode(struct net_device *netdev) static int nfp_net_change_mtu(struct net_device *netdev, int new_mtu) { struct nfp_net *nn = netdev_priv(netdev); + int ret = 0; u32 tmp; nn_dbg(nn, "New MTU = %d\n", new_mtu); @@ -1929,10 +1930,10 @@ static int nfp_net_change_mtu(struct net_device *netdev, int new_mtu) /* restart if running */ if (netif_running(netdev)) { nfp_net_netdev_close(netdev); - nfp_net_netdev_open(netdev); + ret = nfp_net_netdev_open(netdev); } - return 0; + return ret; } static struct rtnl_link_stats64 *nfp_net_stat64(struct net_device *netdev,