| Message ID | 1451427722-2672-1-git-send-email-xypron.glpk@gmx.de |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
Hi Heinrich, On 12/29/2015 11:22 PM, Heinrich Schuchardt wrote: > IOCTL SIOCRTMSG does nothing but return EINVAL. > > So comment it as unused. Can you say something about how you confirmed this? It's not immediately obvious from the code. Cheers, Michael > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > --- > include/uapi/linux/sockios.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h > index e888b1a..8e7890b 100644 > --- a/include/uapi/linux/sockios.h > +++ b/include/uapi/linux/sockios.h > @@ -27,7 +27,7 @@ > /* Routing table calls. */ > #define SIOCADDRT 0x890B /* add routing table entry */ > #define SIOCDELRT 0x890C /* delete routing table entry */ > -#define SIOCRTMSG 0x890D /* call to routing system */ > +#define SIOCRTMSG 0x890D /* unused */ > > /* Socket configuration controls. */ > #define SIOCGIFNAME 0x8910 /* get iface name */ >
On 12/30/2015 11:56 AM, Michael Kerrisk (man-pages) wrote: > Hi Heinrich, > > On 12/29/2015 11:22 PM, Heinrich Schuchardt wrote: >> IOCTL SIOCRTMSG does nothing but return EINVAL. >> >> So comment it as unused. > > Can you say something about how you confirmed this? > It's not immediately obvious from the code. > > Cheers, > > Michael grep -GHrn SIOCRTMSG SIOCRTMSG is only used in: * net/ipv4/af_inet.c * include/uapi/linux/sockios.h inet_ioctl calls ip_rt_ioctl. ip_rt_ioctl only handles SIOCADDRT and SIOCDELRT and returns -EINVAL otherwise. cf. http://lkml.iu.edu/hypermail/linux/kernel/0911.0/02636.html Best regards Heinrich > > >> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> >> --- >> include/uapi/linux/sockios.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h >> index e888b1a..8e7890b 100644 >> --- a/include/uapi/linux/sockios.h >> +++ b/include/uapi/linux/sockios.h >> @@ -27,7 +27,7 @@ >> /* Routing table calls. */ >> #define SIOCADDRT 0x890B /* add routing table entry */ >> #define SIOCDELRT 0x890C /* delete routing table entry */ >> -#define SIOCRTMSG 0x890D /* call to routing system */ >> +#define SIOCRTMSG 0x890D /* unused */ >> >> /* Socket configuration controls. */ >> #define SIOCGIFNAME 0x8910 /* get iface name */ >> > > -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Heinrich Schuchardt <xypron.glpk@gmx.de> Date: Tue, 29 Dec 2015 23:22:02 +0100 > IOCTL SIOCRTMSG does nothing but return EINVAL. > > So comment it as unused. > > Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> Please enhance your commit log message to include the analysis you provided in your reply to Michael Kerrisk. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/include/uapi/linux/sockios.h b/include/uapi/linux/sockios.h index e888b1a..8e7890b 100644 --- a/include/uapi/linux/sockios.h +++ b/include/uapi/linux/sockios.h @@ -27,7 +27,7 @@ /* Routing table calls. */ #define SIOCADDRT 0x890B /* add routing table entry */ #define SIOCDELRT 0x890C /* delete routing table entry */ -#define SIOCRTMSG 0x890D /* call to routing system */ +#define SIOCRTMSG 0x890D /* unused */ /* Socket configuration controls. */ #define SIOCGIFNAME 0x8910 /* get iface name */
IOCTL SIOCRTMSG does nothing but return EINVAL. So comment it as unused. Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de> --- include/uapi/linux/sockios.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)