From patchwork Tue Dec 15 17:11:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Bolle X-Patchwork-Id: 557019 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 317081402C4 for ; Wed, 16 Dec 2015 04:12:54 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965253AbbLORLj (ORCPT ); Tue, 15 Dec 2015 12:11:39 -0500 Received: from lb2-smtp-cloud2.xs4all.net ([194.109.24.25]:37146 "EHLO lb2-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965064AbbLORLh (ORCPT ); Tue, 15 Dec 2015 12:11:37 -0500 Received: from localhost.localdomain ([83.160.161.190]) by smtp-cloud2.xs4all.net with ESMTP id ttBY1r00B46mmVf01tBcQL; Tue, 15 Dec 2015 18:11:36 +0100 From: Paul Bolle To: netdev@vger.kernel.org Cc: Tilman Schmidt , Alan Cox , Sasha Levin , Peter Hurley , linux-kernel@vger.kernel.org Subject: [PATCH 4/4] ser_gigaset: remove unnecessary kfree() calls from release method Date: Tue, 15 Dec 2015 18:11:31 +0100 Message-Id: <1450199491-30471-5-git-send-email-pebolle@tiscali.nl> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1450199491-30471-1-git-send-email-pebolle@tiscali.nl> References: <1450199491-30471-1-git-send-email-pebolle@tiscali.nl> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tilman Schmidt device->platform_data and platform_device->resource are never used and remain NULL through their entire life. Drops the kfree() calls for them from the device release method. Signed-off-by: Tilman Schmidt Signed-off-by: Paul Bolle --- drivers/isdn/gigaset/ser-gigaset.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/isdn/gigaset/ser-gigaset.c b/drivers/isdn/gigaset/ser-gigaset.c index 635baaf34e95..2a506fe0c8a4 100644 --- a/drivers/isdn/gigaset/ser-gigaset.c +++ b/drivers/isdn/gigaset/ser-gigaset.c @@ -373,13 +373,8 @@ static void gigaset_freecshw(struct cardstate *cs) static void gigaset_device_release(struct device *dev) { - struct platform_device *pdev = to_platform_device(dev); struct cardstate *cs = dev_get_drvdata(dev); - /* adapted from platform_device_release() in drivers/base/platform.c */ - kfree(dev->platform_data); - kfree(pdev->resource); - if (!cs) return; dev_set_drvdata(dev, NULL);