From patchwork Fri Oct 30 12:48:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Vasut X-Patchwork-Id: 538299 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 676EC140E1A for ; Fri, 30 Oct 2015 23:48:32 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030508AbbJ3Ms2 (ORCPT ); Fri, 30 Oct 2015 08:48:28 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:56857 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758368AbbJ3Ms1 (ORCPT ); Fri, 30 Oct 2015 08:48:27 -0400 Received: from mail.nefkom.net (unknown [192.168.8.184]) by mail-out.m-online.net (Postfix) with ESMTP id 3nnNjP4CvHz3hjNm; Fri, 30 Oct 2015 13:48:25 +0100 (CET) X-Auth-Info: uI2/pYE9DYNBp0fhc/Y/D7rWzKcTgb9ZsXjxbbXTUwM= Received: from chi.lan (unknown [195.140.253.167]) by smtp-auth.mnet-online.de (Postfix) with ESMTPA id 3nnNjP22xtzvdWS; Fri, 30 Oct 2015 13:48:25 +0100 (CET) From: Marek Vasut To: linux-can@vger.kernel.org Cc: Marek Vasut , Wolfgang Grandegger , Marc Kleine-Budde , netdev@vger.kernel.org Subject: [PATCH] can: Use correct type in sizeof() in nla_put() Date: Fri, 30 Oct 2015 13:48:19 +0100 Message-Id: <1446209299-6250-1-git-send-email-marex@denx.de> X-Mailer: git-send-email 2.1.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The sizeof() is invoked on an incorrect variable, likely due to some copy-paste error, and this might result in memory corruption. Fix this. Signed-off-by: Marek Vasut Cc: Wolfgang Grandegger Cc: Marc Kleine-Budde Cc: netdev@vger.kernel.org --- drivers/net/can/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) NOTE: I only compile-tested this. diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index aede704..141c2a4 100644 --- a/drivers/net/can/dev.c +++ b/drivers/net/can/dev.c @@ -915,7 +915,7 @@ static int can_fill_info(struct sk_buff *skb, const struct net_device *dev) nla_put(skb, IFLA_CAN_BITTIMING_CONST, sizeof(*priv->bittiming_const), priv->bittiming_const)) || - nla_put(skb, IFLA_CAN_CLOCK, sizeof(cm), &priv->clock) || + nla_put(skb, IFLA_CAN_CLOCK, sizeof(priv->clock), &priv->clock) || nla_put_u32(skb, IFLA_CAN_STATE, state) || nla_put(skb, IFLA_CAN_CTRLMODE, sizeof(cm), &cm) || nla_put_u32(skb, IFLA_CAN_RESTART_MS, priv->restart_ms) ||