From patchwork Tue Oct 27 19:02:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Punit Vara X-Patchwork-Id: 536807 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id DA39514134B for ; Wed, 28 Oct 2015 06:06:15 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=vGtb67mK; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965384AbbJ0TEM (ORCPT ); Tue, 27 Oct 2015 15:04:12 -0400 Received: from mail-wi0-f196.google.com ([209.85.212.196]:35407 "EHLO mail-wi0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964950AbbJ0TEK (ORCPT ); Tue, 27 Oct 2015 15:04:10 -0400 Received: by wicuv6 with SMTP id uv6so29613030wic.2; Tue, 27 Oct 2015 12:04:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=l34SaQzFZtdokVOmDtp49JFufp1s0ofei+/zo8eGhzI=; b=vGtb67mKi6hm9C1+EWyBq0U9fbUs05NfEW0wQwG+fH2Fb+TAxwb6iqvzrmCZzUQ7HE r5m6tZuVJ3D19SBY0AwDNqDCGype8VZWnhB7bFGotfCzj0Ch5FZWYcDf/1bm+AFDrD0T MSANtswphjBnRtFwO/N09TvkODktq3hHCNHyZJy7jcyss/piBp06ZT7nQlYNd5ALhXX6 zM/znaV1Ztz777n0uCtd+Xck5Oww7v1kiPCg6IUA79jM4a7PcxFflesXAsh8TmDzwmY4 5TN8ZyzIdiMS//3iLpnXTcNtRkTws3ghe/bo2fjz/1PXm9QqQpbGVp67lnnatLj2MNdG fztA== X-Received: by 10.194.143.43 with SMTP id sb11mr54050141wjb.120.1445972648839; Tue, 27 Oct 2015 12:04:08 -0700 (PDT) Received: from localhost.localdomain ([163.47.15.144]) by smtp.gmail.com with ESMTPSA id hk5sm46320620wjb.6.2015.10.27.12.04.03 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Oct 2015 12:04:07 -0700 (PDT) From: Punit Vara To: kvalo@qca.qualcomm.com Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Punit Vara Subject: [RESEND PATCH 06/10] net: wireless: ath: simplify return flow for carl9170_regwrite_result() Date: Wed, 28 Oct 2015 00:32:41 +0530 Message-Id: <1445972565-14963-6-git-send-email-punitvara@gmail.com> X-Mailer: git-send-email 2.5.3 In-Reply-To: <1445972565-14963-1-git-send-email-punitvara@gmail.com> References: <1445972565-14963-1-git-send-email-punitvara@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch is to the carl9170/phy.c file that fixes warning reported by coccicheck : WARNING: end returns can be simplified I have removed unneccessary variable declaration and simply return flow for carl9170_regwrite_result() Signed-off-by: Punit Vara --- drivers/net/wireless/ath/carl9170/phy.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/carl9170/phy.c b/drivers/net/wireless/ath/carl9170/phy.c index dca6df1..f3b5434 100644 --- a/drivers/net/wireless/ath/carl9170/phy.c +++ b/drivers/net/wireless/ath/carl9170/phy.c @@ -966,7 +966,6 @@ static const struct carl9170_phy_freq_entry carl9170_phy_freq_params[] = { static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz, u32 freq, enum carl9170_bw bw) { - int err; u32 d0, d1, td0, td1, fd0, fd1; u8 chansel; u8 refsel0 = 1, refsel1 = 0; @@ -1024,11 +1023,7 @@ static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz, carl9170_regwrite(0x1c58e8, fd1); carl9170_regwrite_finish(); - err = carl9170_regwrite_result(); - if (err) - return err; - - return 0; + return carl9170_regwrite_result(); } static const struct carl9170_phy_freq_params *