From patchwork Wed Oct 21 14:55:32 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Punit Vara X-Patchwork-Id: 533857 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 309C014076E for ; Thu, 22 Oct 2015 01:58:49 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=EaquDEuA; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755432AbbJUO6j (ORCPT ); Wed, 21 Oct 2015 10:58:39 -0400 Received: from mail-wi0-f196.google.com ([209.85.212.196]:36619 "EHLO mail-wi0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751996AbbJUO6f (ORCPT ); Wed, 21 Oct 2015 10:58:35 -0400 Received: by wibvt6 with SMTP id vt6so13023733wib.3; Wed, 21 Oct 2015 07:58:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=l34SaQzFZtdokVOmDtp49JFufp1s0ofei+/zo8eGhzI=; b=EaquDEuACGM+eLB3Lmomq3pPNSK8F76GcafZhb5QJ01M2qNsinPlrRlXZ1nwfZ0mY7 vMnwiSHM+1VQ5YiZm7pLk8eivBx+X6S8mZNZS5KpG+Tcd0229hw9NUbDfK3Oc5tiuZ/8 lRHPunmML18zfW4fvqMVSSLnnIoFYZ+HqAaWZIHBJ516dQBOA43Tmffsso5mNHWCXyCz COC2WtdbU6PcJ5Vw0qWLreWZ69ayspxHLdpcKCDbg5R7ntnFXCKcaZDYkXVjDEH9jxX0 EA4Vgv/3JFQ7g9UhqmU3m1tNZSbq2sAUCcaheBK4CWqqT5qhyskByl/0pQz7Av9QBxhO ccTw== X-Received: by 10.194.242.167 with SMTP id wr7mr11437478wjc.27.1445439513909; Wed, 21 Oct 2015 07:58:33 -0700 (PDT) Received: from localhost.localdomain ([163.47.15.42]) by smtp.gmail.com with ESMTPSA id o10sm7659201wia.4.2015.10.21.07.58.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Oct 2015 07:58:33 -0700 (PDT) From: Punit Vara To: kvalo@qca.qualcomm.com Cc: stas.yakovlev@gmail.com, chaoming_li@realsil.com.cn, Larry.Finger@lwfinger.net, chunkeey@googlemail.com, sgruszka@redhat.com, brudley@broadcom.com, arend@broadcom.com, linville@tuxdriver.com, jirislaby@gmail.com, mickflemm@gmail.com, mcgrof@do-not-panic.com, k.eugene.e@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211-dev-list@broadcom.com, wcn36xx@lists.infradead.org, johannes.berg@intel.com, meuleman@broadcom.com, Punit Vara Subject: [PATCH 10/15] net: wireless: ath: simplify return flow for carl9170_regwrite_result() Date: Wed, 21 Oct 2015 20:25:32 +0530 Message-Id: <1445439337-19055-11-git-send-email-punitvara@gmail.com> X-Mailer: git-send-email 2.5.3 In-Reply-To: <1445439337-19055-1-git-send-email-punitvara@gmail.com> References: <1445439337-19055-1-git-send-email-punitvara@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch is to the carl9170/phy.c file that fixes warning reported by coccicheck : WARNING: end returns can be simplified I have removed unneccessary variable declaration and simply return flow for carl9170_regwrite_result() Signed-off-by: Punit Vara --- drivers/net/wireless/ath/carl9170/phy.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/net/wireless/ath/carl9170/phy.c b/drivers/net/wireless/ath/carl9170/phy.c index dca6df1..f3b5434 100644 --- a/drivers/net/wireless/ath/carl9170/phy.c +++ b/drivers/net/wireless/ath/carl9170/phy.c @@ -966,7 +966,6 @@ static const struct carl9170_phy_freq_entry carl9170_phy_freq_params[] = { static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz, u32 freq, enum carl9170_bw bw) { - int err; u32 d0, d1, td0, td1, fd0, fd1; u8 chansel; u8 refsel0 = 1, refsel1 = 0; @@ -1024,11 +1023,7 @@ static int carl9170_init_rf_bank4_pwr(struct ar9170 *ar, bool band5ghz, carl9170_regwrite(0x1c58e8, fd1); carl9170_regwrite_finish(); - err = carl9170_regwrite_result(); - if (err) - return err; - - return 0; + return carl9170_regwrite_result(); } static const struct carl9170_phy_freq_params *