From patchwork Wed Oct 21 14:55:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Punit Vara X-Patchwork-Id: 533864 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4B33B140DAF for ; Thu, 22 Oct 2015 02:02:46 +1100 (AEDT) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b=wxkAeOA5; dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753999AbbJUO60 (ORCPT ); Wed, 21 Oct 2015 10:58:26 -0400 Received: from mail-wi0-f193.google.com ([209.85.212.193]:35599 "EHLO mail-wi0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752016AbbJUO6X (ORCPT ); Wed, 21 Oct 2015 10:58:23 -0400 Received: by wicuv6 with SMTP id uv6so12971013wic.2; Wed, 21 Oct 2015 07:58:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ltGAS3H/MXgzJGUhYf4Rpkv7nCTwEG9aDMqrZWjDe+0=; b=wxkAeOA5Nfcn9GIFTghCN3gfnJ5ZTp3XvzVZx5ZaAVAQF+xGNgaBNmgosNflL7mZe3 r3wy8IZ/k72cLNeQfViJG5t8siSkrvauFKQ0GQaaiwfB09F9n/PeXNxUPUT2V/IRZCk7 gM0wgowywMeWytA58pgNIT9Lc6w1hRM3IFiqyYlE1tB7tezwQ1l2jrxEPLpnKnbqdLa/ VaF3YUgQBNjcHLIj5L3jl7nYebNuoXga+lI/p/TLU3KarZOtnYSJJUIY2IVXyWO19au9 mLYO1dU6fB9j2aIyBQ9aca9R6cG4fokqdW8kmCcykUkbI9aQrwATOMGaxLvPqT2ajC8E 4KSQ== X-Received: by 10.180.182.84 with SMTP id ec20mr12025017wic.42.1445439502569; Wed, 21 Oct 2015 07:58:22 -0700 (PDT) Received: from localhost.localdomain ([163.47.15.42]) by smtp.gmail.com with ESMTPSA id o10sm7659201wia.4.2015.10.21.07.58.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 21 Oct 2015 07:58:21 -0700 (PDT) From: Punit Vara To: kvalo@qca.qualcomm.com Cc: stas.yakovlev@gmail.com, chaoming_li@realsil.com.cn, Larry.Finger@lwfinger.net, chunkeey@googlemail.com, sgruszka@redhat.com, brudley@broadcom.com, arend@broadcom.com, linville@tuxdriver.com, jirislaby@gmail.com, mickflemm@gmail.com, mcgrof@do-not-panic.com, k.eugene.e@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, brcm80211-dev-list@broadcom.com, wcn36xx@lists.infradead.org, johannes.berg@intel.com, meuleman@broadcom.com, Punit Vara Subject: [PATCH 09/15] net: wireless: simplify return flow for zd1201_setconfig16 Date: Wed, 21 Oct 2015 20:25:31 +0530 Message-Id: <1445439337-19055-10-git-send-email-punitvara@gmail.com> X-Mailer: git-send-email 2.5.3 In-Reply-To: <1445439337-19055-1-git-send-email-punitvara@gmail.com> References: <1445439337-19055-1-git-send-email-punitvara@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch is to the zd1201.c file that fixes up warning reported by coccicheck: WARNING: end returns can be simplified and declaration on line 1658 can be dropped Prefer direct return value instead of writing 2-3 more sentence. Signed-off-by: Punit Vara --- drivers/net/wireless/zd1201.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/wireless/zd1201.c b/drivers/net/wireless/zd1201.c index 6f5c793..d9e67d9 100644 --- a/drivers/net/wireless/zd1201.c +++ b/drivers/net/wireless/zd1201.c @@ -1655,15 +1655,11 @@ static int zd1201_set_maxassoc(struct net_device *dev, struct iw_request_info *info, struct iw_param *rrq, char *extra) { struct zd1201 *zd = netdev_priv(dev); - int err; if (!zd->ap) return -EOPNOTSUPP; - err = zd1201_setconfig16(zd, ZD1201_RID_CNFMAXASSOCSTATIONS, rrq->value); - if (err) - return err; - return 0; + return zd1201_setconfig16(zd, ZD1201_RID_CNFMAXASSOCSTATIONS, rrq->value); } static int zd1201_get_maxassoc(struct net_device *dev,