From patchwork Thu Oct 15 15:43:21 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Pirko X-Patchwork-Id: 530777 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 6ED1B1402D6 for ; Fri, 16 Oct 2015 02:44:20 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753832AbbJOPnn (ORCPT ); Thu, 15 Oct 2015 11:43:43 -0400 Received: from mail-lf0-f43.google.com ([209.85.215.43]:33894 "EHLO mail-lf0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753761AbbJOPnl (ORCPT ); Thu, 15 Oct 2015 11:43:41 -0400 Received: by lfaz124 with SMTP id z124so33138718lfa.1 for ; Thu, 15 Oct 2015 08:43:40 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=HO7R2IU6eALmFlvYJRr9vufF+/wcltDM5B0GOH5P44E=; b=bKTHU+2usm+qee4RpicL0U2b8Z64izTI5Pw4lrvC1XH9LI1uyXM2WFEXDf+Vz3mtmm u0BNnbuwypZguW9AxoyyrMdCNFxoK099ZYOGO6DF2qxutM/ORxdkCohgRWANKUJ5kqoM f2xwO1q4QXyDsBkeuu/RcoIlsiuJb+wzsNj1Q5Jf1eJVhaTdYdmPuX/mNaDjOKgZzNwc F5VTExffzu2H4MrYutnxhfYou0GKOpnDxsnMrrIi7IxfMiKyDe1XzjVvVtB8RTbh3j5b hBtzHak/Fz4MQqBS+P1TCGaXsQg+nDU/y5yrinbdOTc6gONbfpPaq6YqL+39ZJp0Iio3 ha3A== X-Gm-Message-State: ALoCoQnnUfpkNyMOAq3D+bMa1cN6vinAClgDTNx+UrLbVaoxYaJFInpHXKuvunhiI/7ioQeaI+cP X-Received: by 10.180.10.101 with SMTP id h5mr11183601wib.22.1444923819974; Thu, 15 Oct 2015 08:43:39 -0700 (PDT) Received: from localhost (ip-94-113-120-24.net.upcbroadband.cz. [94.113.120.24]) by smtp.gmail.com with ESMTPSA id i3sm24068044wij.9.2015.10.15.08.43.39 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Oct 2015 08:43:39 -0700 (PDT) From: Jiri Pirko To: netdev@vger.kernel.org Cc: davem@davemloft.net, idosch@mellanox.com, eladr@mellanox.com Subject: [patch net-next 07/15] mlxsw: core: Do not use EMADs in mlxsw_emad_fini Date: Thu, 15 Oct 2015 17:43:21 +0200 Message-Id: <1444923809-20785-8-git-send-email-jiri@resnulli.us> X-Mailer: git-send-email 1.9.3 In-Reply-To: <1444923809-20785-1-git-send-email-jiri@resnulli.us> References: <1444923809-20785-1-git-send-email-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jiri Pirko Be symmetric with mlxsw_emad_init and don't use EMADs in mlxsw_emad_fini cleanup function. Use command interface instead. Signed-off-by: Jiri Pirko --- drivers/net/ethernet/mellanox/mlxsw/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/mellanox/mlxsw/core.c b/drivers/net/ethernet/mellanox/mlxsw/core.c index 28c19cc..cf7c9d2 100644 --- a/drivers/net/ethernet/mellanox/mlxsw/core.c +++ b/drivers/net/ethernet/mellanox/mlxsw/core.c @@ -556,6 +556,7 @@ static void mlxsw_emad_fini(struct mlxsw_core *mlxsw_core) { char hpkt_pl[MLXSW_REG_HPKT_LEN]; + mlxsw_core->emad.use_emad = false; mlxsw_reg_hpkt_pack(hpkt_pl, MLXSW_REG_HPKT_ACTION_DISCARD, MLXSW_REG_HTGT_TRAP_GROUP_EMAD, MLXSW_TRAP_ID_ETHEMAD);