From patchwork Wed Aug 19 16:46:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jeremy Linton X-Patchwork-Id: 508777 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id BF8D214032C for ; Thu, 20 Aug 2015 02:47:42 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751690AbbHSQrh (ORCPT ); Wed, 19 Aug 2015 12:47:37 -0400 Received: from eu-smtp-delivery-143.mimecast.com ([207.82.80.143]:65294 "EHLO eu-smtp-delivery-143.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751576AbbHSQrd (ORCPT ); Wed, 19 Aug 2015 12:47:33 -0400 Received: from cam-owa2.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.140]) by eu-smtp-1.mimecast.com with ESMTP id uk-mta-8-N2TsLPq8SxG6ttQvSQI9rw-1; Wed, 19 Aug 2015 17:47:31 +0100 Received: from mammon-v1.localdomain.com ([10.1.2.79]) by cam-owa2.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.3959); Wed, 19 Aug 2015 17:47:30 +0100 From: Jeremy Linton To: netdev@vger.kernel.org Cc: gregkh@linuxfoundation.org, steve.glendinning@shawell.net, linux@roeck-us.net, jeremy.linton@arm.com Subject: [PATCH 2/2] smsc911x: Remove dev==NULL check. Date: Wed, 19 Aug 2015 11:46:43 -0500 Message-Id: <1440002803-5113-3-git-send-email-jeremy.linton@arm.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1440002803-5113-1-git-send-email-jeremy.linton@arm.com> References: <1440002803-5113-1-git-send-email-jeremy.linton@arm.com> X-OriginalArrivalTime: 19 Aug 2015 16:47:30.0659 (UTC) FILETIME=[BD228B30:01D0DA9E] X-MC-Unique: N2TsLPq8SxG6ttQvSQI9rw-1 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The dev==NULL check in smsc911x_probe_config is useless and isn't providing any additional protection. If a fwnode doesn't exist then an appropriate error should be returned by device_get_phy_mode() covering the original case of a missing of/fwnode. Signed-off-by: Jeremy Linton --- drivers/net/ethernet/smsc/smsc911x.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/smsc/smsc911x.c b/drivers/net/ethernet/smsc/smsc911x.c index 34f9768..6eef325 100644 --- a/drivers/net/ethernet/smsc/smsc911x.c +++ b/drivers/net/ethernet/smsc/smsc911x.c @@ -2370,9 +2370,6 @@ static int smsc911x_probe_config(struct smsc911x_platform_config *config, int phy_interface; u32 width = 0; - if (!dev) - return -ENODEV; - phy_interface = device_get_phy_mode(dev); if (phy_interface < 0) return phy_interface;