From patchwork Thu Aug 6 12:24:31 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phil Sutter X-Patchwork-Id: 504678 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id EF0361401EF for ; Thu, 6 Aug 2015 22:24:57 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932221AbbHFMYt (ORCPT ); Thu, 6 Aug 2015 08:24:49 -0400 Received: from orbit.nwl.cc ([176.31.251.142]:38069 "EHLO mail.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755678AbbHFMYi (ORCPT ); Thu, 6 Aug 2015 08:24:38 -0400 Received: from mail.nwl.cc (orbit [127.0.0.1]) by mail.nwl.cc (Postfix) with ESMTP id B452921471; Thu, 6 Aug 2015 14:24:36 +0200 (CEST) Received: by mail.nwl.cc (Postfix, from userid 1000) id 9AF1521432; Thu, 6 Aug 2015 14:24:36 +0200 (CEST) From: Phil Sutter To: Stephen Hemminger Cc: netdev@vger.kernel.org Subject: [PATCH 1/6] ip/ipnetns: prevent potential string buffer overflow Date: Thu, 6 Aug 2015 14:24:31 +0200 Message-Id: <1438863876-1935-1-git-send-email-phil@nwl.cc> X-Mailer: git-send-email 2.1.2 X-Virus-Scanned: ClamAV using ClamSMTP Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Signed-off-by: Phil Sutter --- ip/ipnetns.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ip/ipnetns.c b/ip/ipnetns.c index 3b704a4..32b0f51 100644 --- a/ip/ipnetns.c +++ b/ip/ipnetns.c @@ -178,7 +178,8 @@ static int netns_map_add(int nsid, char *name) return -ENOMEM; } c->nsid = nsid; - strcpy(c->name, name); + strncpy(c->name, name, NAME_MAX); + c->name[NAME_MAX - 1] = '\0'; h = NSID_HASH_NSID(nsid); hlist_add_head(&c->nsid_hash, &nsid_head[h]);