From patchwork Tue Jul 28 10:19:19 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Amir Vadai X-Patchwork-Id: 501131 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 351C7140DFC for ; Tue, 28 Jul 2015 20:20:29 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933025AbbG1KUQ (ORCPT ); Tue, 28 Jul 2015 06:20:16 -0400 Received: from [193.47.165.129] ([193.47.165.129]:51910 "EHLO mellanox.co.il" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S932424AbbG1KUN (ORCPT ); Tue, 28 Jul 2015 06:20:13 -0400 Received: from Internal Mail-Server by MTLPINE1 (envelope-from amirv@mellanox.com) with ESMTPS (AES256-SHA encrypted); 28 Jul 2015 13:19:50 +0300 Received: from swl095.mtl.labs.mlnx (swl095.mtl.labs.mlnx [10.7.17.95]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id t6SAJoHZ021660; Tue, 28 Jul 2015 13:19:50 +0300 From: Amir Vadai To: "David S. Miller" Cc: netdev@vger.kernel.org, Hadar Har-Zion , Or Gerlitz , Tal Alon , Amir Vadai Subject: [PATCH net-next] net/mlx4_en: Hardware accelerated 802.1ad works only on the first port Date: Tue, 28 Jul 2015 13:19:19 +0300 Message-Id: <1438078759-21477-1-git-send-email-amirv@mellanox.com> X-Mailer: git-send-email 2.4.3.413.ga5fe668 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Fix mistakenly used, hard coded, port number in get_phv_bit() Fixes: 77fc29c ("net/mlx4_core: Preparations for 802.1ad VLAN support") Signed-off-by: Amir Vadai --- Hi Dave, Because of my mistake I've sent a version [1] without some internal review fixes. This patch fix the only code issue that was missing. The rest were only improvements to the commit messages, which unfortunately it is too late to fix now. [1] - http://www.spinics.net/lists/netdev/msg337148.html Thanks, Amir drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/fw.c b/drivers/net/ethernet/mellanox/mlx4/fw.c index 5a1c3d2..e8ec1de 100644 --- a/drivers/net/ethernet/mellanox/mlx4/fw.c +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c @@ -2815,7 +2815,7 @@ int get_phv_bit(struct mlx4_dev *dev, u8 port, int *phv) struct mlx4_func_cap func_cap; memset(&func_cap, 0, sizeof(func_cap)); - err = mlx4_QUERY_FUNC_CAP(dev, 1, &func_cap); + err = mlx4_QUERY_FUNC_CAP(dev, port, &func_cap); if (!err) *phv = func_cap.flags & QUERY_FUNC_CAP_PHV_BIT; return err;