| Message ID | 1435095970-18576-4-git-send-email-vivien.didelot@savoirfairelinux.com |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | David Miller |
| Headers | show |
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com> Date: Tue, 23 Jun 2015 17:46:10 -0400 > Add support for dumping the VLAN Table Unit entries by pointing to the > port_vlan_dump function implemented for mv88e6xxx. > > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> There is no reason to separate this from patch #2. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jun 23, 2015 at 05:46:10PM -0400, Vivien Didelot wrote: > Add support for dumping the VLAN Table Unit entries by pointing to the > port_vlan_dump function implemented for mv88e6xxx. > > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> > --- > drivers/net/dsa/mv88e6352.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/dsa/mv88e6352.c b/drivers/net/dsa/mv88e6352.c > index b524bd3..c35f57f 100644 > --- a/drivers/net/dsa/mv88e6352.c > +++ b/drivers/net/dsa/mv88e6352.c > @@ -397,6 +397,7 @@ struct dsa_switch_driver mv88e6352_switch_driver = { > .fdb_add = mv88e6xxx_port_fdb_add, > .fdb_del = mv88e6xxx_port_fdb_del, > .fdb_getnext = mv88e6xxx_port_fdb_getnext, > + .port_vlan_dump = mv88e6xxx_port_vlan_dump, > }; Once the code is made generic in terms of number of ports, i would suggest adding this to all drivers which support it. Between us, we can test most of them. Thanks Andrew -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Andrew, On Jun 26, 2015, at 10:12 AM, Andrew Lunn andrew@lunn.ch wrote: > On Tue, Jun 23, 2015 at 05:46:10PM -0400, Vivien Didelot wrote: >> Add support for dumping the VLAN Table Unit entries by pointing to the >> port_vlan_dump function implemented for mv88e6xxx. >> >> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> >> --- >> drivers/net/dsa/mv88e6352.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/dsa/mv88e6352.c b/drivers/net/dsa/mv88e6352.c >> index b524bd3..c35f57f 100644 >> --- a/drivers/net/dsa/mv88e6352.c >> +++ b/drivers/net/dsa/mv88e6352.c >> @@ -397,6 +397,7 @@ struct dsa_switch_driver mv88e6352_switch_driver = { >> .fdb_add = mv88e6xxx_port_fdb_add, >> .fdb_del = mv88e6xxx_port_fdb_del, >> .fdb_getnext = mv88e6xxx_port_fdb_getnext, >> + .port_vlan_dump = mv88e6xxx_port_vlan_dump, >> }; > > Once the code is made generic in terms of number of ports, i would > suggest adding this to all drivers which support it. Between us, we > can test most of them. > > Thanks > Andrew OK. I'll add it in mv88e6352.c, mv88e6171.c, mv88e6131.c, mv88e6123_61_65.c. Thanks, -v -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/dsa/mv88e6352.c b/drivers/net/dsa/mv88e6352.c index b524bd3..c35f57f 100644 --- a/drivers/net/dsa/mv88e6352.c +++ b/drivers/net/dsa/mv88e6352.c @@ -397,6 +397,7 @@ struct dsa_switch_driver mv88e6352_switch_driver = { .fdb_add = mv88e6xxx_port_fdb_add, .fdb_del = mv88e6xxx_port_fdb_del, .fdb_getnext = mv88e6xxx_port_fdb_getnext, + .port_vlan_dump = mv88e6xxx_port_vlan_dump, }; MODULE_ALIAS("platform:mv88e6352");
Add support for dumping the VLAN Table Unit entries by pointing to the port_vlan_dump function implemented for mv88e6xxx. Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com> --- drivers/net/dsa/mv88e6352.c | 1 + 1 file changed, 1 insertion(+)