| Message ID | 1431480899-9818-1-git-send-email-liuhangbin@gmail.com |
|---|---|
| State | Rejected, archived |
| Delegated to: | stephen hemminger |
| Headers | show |
On Wed, 13 May 2015 09:34:59 +0800 Hangbin Liu <liuhangbin@gmail.com> wrote: > 1. Kernel commit a02e4b7 set the default hoplimit as zero. > 2. Kernel should return the correct values and iproute should show what kernel > returns, not invent magic transformations. > > Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> > --- > ip/iproute.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/ip/iproute.c b/ip/iproute.c > index 670a4c6..569bff9 100644 > --- a/ip/iproute.c > +++ b/ip/iproute.c > @@ -579,9 +579,6 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg) > print_rtax_features(fp, val); > break; > case RTAX_HOPLIMIT: > - if ((int)val == -1) > - val = 0; > - /* fall through */ > default: > fprintf(fp, " %u", val); > break; This is going to cause a mess with older kernels. Since val will be -1 people will see that printed as unsigned and freak. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/ip/iproute.c b/ip/iproute.c index 670a4c6..569bff9 100644 --- a/ip/iproute.c +++ b/ip/iproute.c @@ -579,9 +579,6 @@ int print_route(const struct sockaddr_nl *who, struct nlmsghdr *n, void *arg) print_rtax_features(fp, val); break; case RTAX_HOPLIMIT: - if ((int)val == -1) - val = 0; - /* fall through */ default: fprintf(fp, " %u", val); break;
1. Kernel commit a02e4b7 set the default hoplimit as zero. 2. Kernel should return the correct values and iproute should show what kernel returns, not invent magic transformations. Signed-off-by: Hangbin Liu <liuhangbin@gmail.com> --- ip/iproute.c | 3 --- 1 file changed, 3 deletions(-)