From patchwork Wed May 6 16:58:02 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 469049 X-Patchwork-Delegate: shemminger@vyatta.com Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 858B814012C for ; Thu, 7 May 2015 02:58:54 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbbEFQ6t (ORCPT ); Wed, 6 May 2015 12:58:49 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:32905 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753143AbbEFQ6E (ORCPT ); Wed, 6 May 2015 12:58:04 -0400 Received: by pacwv17 with SMTP id wv17so14628601pac.0 for ; Wed, 06 May 2015 09:58:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=v58PXVbKSkKVTWCoBYldoLfwen4KXkwlBOmZg+wZxOI=; b=hVlCWfG+xUwqYPtylQViTMJX1bxsVnxgCuBtXIXJ9W4sDccX94PyBOpUIXotNUI3eU sgHCVC+5v/0MIgOPE16fwVndxsLmsdpTAfyY9Rjcp2M1jV+qbj9VcRgM4hLPS/Vmixm4 mOmMQXQt7Z9v5IiuEOCiriE0Ymm2b1lgQCF69YC3JojKyH6mcmExiZvcTwu5HwG+tG53 7DzUPjqYPSKyfAgXAyayBe2uODgGOtq0IZ59H2QpJUrLpRvAwcJp2mYeufx+zBgN2v4M 6P13mjO1tzlmvJ6wnGk6JArFaHMVHLze85cxCqSM4XfNHO452Uu+zOicJMbmzeP8nbgQ VigA== X-Gm-Message-State: ALoCoQmgT5N/H08j+wTmgzJpUQf+Ml/E8I1ZssYE+Ow2o9x5XAHHiFKMWOZ90QZ0c251tmidEYzs X-Received: by 10.68.173.66 with SMTP id bi2mr61795600pbc.5.1430931484261; Wed, 06 May 2015 09:58:04 -0700 (PDT) Received: from urahara.home.lan (static-50-53-82-155.bvtn.or.frontiernet.net. [50.53.82.155]) by mx.google.com with ESMTPSA id id2sm2363629pbb.56.2015.05.06.09.58.03 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 May 2015 09:58:03 -0700 (PDT) From: Stephen Hemminger To: netdev@vger.kernel.org Cc: Stephen Hemminger Subject: [PATCH 3/4] ip: fix exit code for rule failures Date: Wed, 6 May 2015 09:58:02 -0700 Message-Id: <1430931483-28595-4-git-send-email-stephen@networkplumber.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1430931483-28595-1-git-send-email-stephen@networkplumber.org> References: <1430931483-28595-1-git-send-email-stephen@networkplumber.org> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Stephen Hemminger If ip rule command fails talking to kernel, exit code should be 2. The sub-command is called by cmd loop and the exit code is negative of return value from the command callback. --- ip/iprule.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ip/iprule.c b/ip/iprule.c index 967969c..986a5bc 100644 --- a/ip/iprule.c +++ b/ip/iprule.c @@ -381,7 +381,7 @@ static int iprule_modify(int cmd, int argc, char **argv) req.r.rtm_table = RT_TABLE_MAIN; if (rtnl_talk(&rth, &req.n, 0, 0, NULL) < 0) - return 2; + return -2; return 0; }