diff mbox

[PATCHv3] pppoe: Lacks DST MAC address check

Message ID 1429556868-28640-1-git-send-email-joakim.tjernlund@transmode.se
State Accepted, archived
Delegated to: David Miller
Headers show

Commit Message

Joakim Tjernlund April 20, 2015, 7:07 p.m. UTC 
From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>

A pppoe session is identified by its session ID and MAC address.
Currently pppoe does not check if the received pkg has the correct
MAC address. This is a problem when the eth I/F is in promisc mode
as then any DST MAC address is accepted.

Signed-off-by: Joakim Tjernlund <joakim.tjernlund@transmode.se>
---
 drivers/net/ppp/pppoe.c | 3 +++
 1 file changed, 3 insertions(+)

v2 - The MAC address check should encompass all pppoe pkgs,
     not only the relay type.

v3 - Add signoff

Comments

David Miller April 20, 2015, 7:27 p.m. UTC | #1 
From: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Date: Mon, 20 Apr 2015 21:07:48 +0200

> From: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
> 
> A pppoe session is identified by its session ID and MAC address.
> Currently pppoe does not check if the received pkg has the correct
> MAC address. This is a problem when the eth I/F is in promisc mode
> as then any DST MAC address is accepted.
> 
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund@transmode.se>
> ---
>  drivers/net/ppp/pppoe.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> v2 - The MAC address check should encompass all pppoe pkgs,
>      not only the relay type.
> 
> v3 - Add signoff

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index ff059e1..aa1dd92 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -380,6 +380,9 @@  static int pppoe_rcv_core(struct sock *sk, struct sk_buff *skb)
 	 * can't change.
 	 */
 
+	if (skb->pkt_type == PACKET_OTHERHOST)
+		goto abort_kfree;
+
 	if (sk->sk_state & PPPOX_BOUND) {
 		ppp_input(&po->chan, skb);
 	} else if (sk->sk_state & PPPOX_RELAY) {