diff mbox

pppoe: Lacks DST MAC address check

Message ID 1429294628-4928-1-git-send-email-Joakim.Tjernlund@transmode.se
State Superseded, archived
Delegated to: David Miller
Headers show

Commit Message

Joakim Tjernlund April 17, 2015, 6:17 p.m. UTC 
A pppoe session is identified by its session ID and MAC address.
Currently pppoe does not check if the received pkg has the correct
MAC address. This is a problem when the eth I/F is in promisc mode
as then any DST MAC address is accepted.

Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund@transmode.se>
---
 drivers/net/ppp/pppoe.c | 3 +++
 1 file changed, 3 insertions(+)
diff mbox

Patch

diff --git a/drivers/net/ppp/pppoe.c b/drivers/net/ppp/pppoe.c
index ff059e1..740e39b 100644
--- a/drivers/net/ppp/pppoe.c
+++ b/drivers/net/ppp/pppoe.c
@@ -383,6 +383,9 @@  static int pppoe_rcv_core(struct sock *sk, struct sk_buff *skb)
 	if (sk->sk_state & PPPOX_BOUND) {
 		ppp_input(&po->chan, skb);
 	} else if (sk->sk_state & PPPOX_RELAY) {
+		if (skb->pkt_type == PACKET_OTHERHOST)
+			goto abort_kfree;
+
 		relay_po = get_item_by_addr(sock_net(sk),
 					    &po->pppoe_relay);
 		if (relay_po == NULL)