From patchwork Mon Apr 6 23:41:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Cong Wang X-Patchwork-Id: 458540 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4AF2F14028F for ; Tue, 7 Apr 2015 09:42:05 +1000 (AEST) Authentication-Results: ozlabs.org; dkim=fail reason="verification failed; unprotected key" header.d=gmail.com header.i=@gmail.com header.b=GpK7Xgo8; dkim-adsp=none (unprotected policy); dkim-atps=neutral Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753173AbbDFXmA (ORCPT ); Mon, 6 Apr 2015 19:42:00 -0400 Received: from mail-pa0-f50.google.com ([209.85.220.50]:33008 "EHLO mail-pa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753026AbbDFXln (ORCPT ); Mon, 6 Apr 2015 19:41:43 -0400 Received: by paboj16 with SMTP id oj16so59123791pab.0 for ; Mon, 06 Apr 2015 16:41:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=+vRGxbiL0SWKZmoSi2mUJz6/c1trsp2zOUjJPIyLiEY=; b=GpK7Xgo8jCrzV36G6AB2MYzRj2abDVEsiU9C1a50P0dHZsVelhZGrpa1PYqb5h8em7 IjWSHhz5nJXaG+5HCUniT/ylMcm2ka+Miewca2P+VqwPoHn/57f5HxhZ/o4XlICIkqBL xbdVyykV/5FgiiE/TvBayZdTSwOmdk3eAFm6Aj1YlGx+BI7vb6oqGqnZAHzABf3F/NbW GssjpW8xmsVEstjdd2Og9zxbAFgga/QQZFc0o5RYl50oB9VUYDLHn3+tx7t3LipbAyOW lDcPT8gnByoF4sJs1CdEJ/OYM6mWx5TwdEr7mepg2Gkx7G/4a2TXB5SyMTGHWFoJk2VK HhAw== X-Received: by 10.70.89.237 with SMTP id br13mr31585114pdb.135.1428363703074; Mon, 06 Apr 2015 16:41:43 -0700 (PDT) Received: from localhost.net ([8.25.197.27]) by mx.google.com with ESMTPSA id hs4sm5874958pdb.30.2015.04.06.16.41.41 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Apr 2015 16:41:42 -0700 (PDT) From: Cong Wang To: netdev@vger.kernel.org Cc: Tom Herbert , Cong Wang Subject: [Patch net-next 2/5] fou: exit early when parsing config fails Date: Mon, 6 Apr 2015 16:41:27 -0700 Message-Id: <1428363690-16288-3-git-send-email-xiyou.wangcong@gmail.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1428363690-16288-1-git-send-email-xiyou.wangcong@gmail.com> References: <1428363690-16288-1-git-send-email-xiyou.wangcong@gmail.com> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Cc: Tom Herbert Signed-off-by: Cong Wang --- net/ipv4/fou.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/ipv4/fou.c b/net/ipv4/fou.c index c8db627..ad0ee82 100644 --- a/net/ipv4/fou.c +++ b/net/ipv4/fou.c @@ -605,8 +605,11 @@ static int fou_nl_cmd_add_port(struct sk_buff *skb, struct genl_info *info) static int fou_nl_cmd_rm_port(struct sk_buff *skb, struct genl_info *info) { struct fou_cfg cfg; + int err; - parse_nl_config(info, &cfg); + err = parse_nl_config(info, &cfg); + if (err) + return err; return fou_destroy(&init_net, &cfg); }