From patchwork Thu Feb 5 11:31:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kiran Padwal X-Patchwork-Id: 436759 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 091A114017B for ; Thu, 5 Feb 2015 22:42:13 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757146AbbBELmH (ORCPT ); Thu, 5 Feb 2015 06:42:07 -0500 Received: from smtp97.ord1c.emailsrvr.com ([108.166.43.97]:60240 "EHLO smtp97.ord1c.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752155AbbBELmG (ORCPT ); Thu, 5 Feb 2015 06:42:06 -0500 X-Greylist: delayed 514 seconds by postgrey-1.27 at vger.kernel.org; Thu, 05 Feb 2015 06:42:06 EST Received: from smtp5.relay.ord1c.emailsrvr.com (localhost.localdomain [127.0.0.1]) by smtp5.relay.ord1c.emailsrvr.com (SMTP Server) with ESMTP id E71E918029B; Thu, 5 Feb 2015 06:33:31 -0500 (EST) Received: by smtp5.relay.ord1c.emailsrvr.com (Authenticated sender: kiran.padwal-AT-smartplayin.com) with ESMTPSA id CF680180344; Thu, 5 Feb 2015 06:33:29 -0500 (EST) X-Sender-Id: kiran.padwal@smartplayin.com Received: from SPINITDTDL00291.smartplayin.local ([UNAVAILABLE]. [220.227.185.53]) (using TLSv1.1 with cipher DHE-RSA-AES256-SHA) by 0.0.0.0:587 (trex/5.4.2); Thu, 05 Feb 2015 11:33:31 GMT From: Kiran Padwal To: "David S. Miller" Cc: Michael Grzeschik , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Kiran Padwal , Kiran Padwal Subject: [PATCH] ARCNET: Add missing error check for devm_kzalloc Date: Thu, 5 Feb 2015 17:01:37 +0530 Message-Id: <1423135897-20448-1-git-send-email-kiran.padwal@smartplayin.com> X-Mailer: git-send-email 1.7.9.5 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org This patch add a missing check on the return value of devm_kzalloc, which would cause a NULL pointer dereference in a OOM situation. Signed-off-by: Kiran Padwal --- drivers/net/arcnet/com20020-pci.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/arcnet/com20020-pci.c b/drivers/net/arcnet/com20020-pci.c index 6c99ff0..945f532 100644 --- a/drivers/net/arcnet/com20020-pci.c +++ b/drivers/net/arcnet/com20020-pci.c @@ -78,6 +78,9 @@ static int com20020pci_probe(struct pci_dev *pdev, const struct pci_device_id *i priv = devm_kzalloc(&pdev->dev, sizeof(struct com20020_priv), GFP_KERNEL); + if (!priv) + return -ENOMEM; + ci = (struct com20020_pci_card_info *)id->driver_data; priv->ci = ci;