From patchwork Fri Dec 26 07:05:03 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Gartrell X-Patchwork-Id: 424095 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id D2EA7140082 for ; Fri, 26 Dec 2014 18:05:30 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751496AbaLZHFO (ORCPT ); Fri, 26 Dec 2014 02:05:14 -0500 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:30295 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751078AbaLZHFM (ORCPT ); Fri, 26 Dec 2014 02:05:12 -0500 Received: from pps.filterd (m0004346 [127.0.0.1]) by mx0a-00082601.pphosted.com (8.14.5/8.14.5) with SMTP id sBQ73oeZ013161 for ; Thu, 25 Dec 2014 23:05:11 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fb.com; h=from : to : cc : subject : date : message-id : mime-version : content-type; s=facebook; bh=Ws7vzYhK5+e4pULMXTGvB2AIwGdKm6qd27QaJwzomrk=; b=ONrKeJqceJBJnOiMMqIG4ZO7rXL3gA8TO/PrveTQUFt0GZHJcyK6FjMVOyf7EGnSSjR/ m6DMXqwSE6CNc2Dr8yyhkadhojreCopCdKYTHaNoFTkFZASTFzdlYa55QHFcqL0N4MEN ya7tKztkedhR205f7q3oQKMJWf16oPs7lTI= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 1rh28682vc-1 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=OK) for ; Thu, 25 Dec 2014 23:05:11 -0800 Received: from mx-out.facebook.com (192.168.57.29) by PRN-CHUB05.TheFacebook.com (192.168.16.15) with Microsoft SMTP Server (TLS) id 14.3.195.1; Thu, 25 Dec 2014 23:05:09 -0800 Received: from facebook.com (2401:db00:20:7017:face:0:13:0) by mx-out.facebook.com (10.212.232.63) with ESMTP id 86c3ab108ccd11e4aed80002c992ebde-d46dd390 for ; Thu, 25 Dec 2014 23:05:08 -0800 Received: by devbig020.prn2.facebook.com (Postfix, from userid 4221) id C77F768C159A; Thu, 25 Dec 2014 23:05:07 -0800 (PST) From: Alex Gartrell To: , CC: , , , Alex Gartrell Subject: [PATCH net-next] tun: Fixed unsigned/signed comparison Date: Thu, 25 Dec 2014 23:05:03 -0800 Message-ID: <1419577503-12862-1-git-send-email-agartrell@fb.com> X-Mailer: git-send-email 1.8.1 X-FB-Internal: Safe MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.13.68, 1.0.33, 0.0.0000 definitions=2014-12-25_06:2014-12-24, 2014-12-25, 1970-01-01 signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 kscore.is_bulkscore=6.32272012524027e-14 kscore.compositescore=0 circleOfTrustscore=514.84 compositescore=0.996321851895651 urlsuspect_oldscore=0.996321851895651 suspectscore=0 recipient_domain_to_sender_totalscore=0 phishscore=0 bulkscore=0 kscore.is_spamscore=0 recipient_to_sender_totalscore=0 recipient_domain_to_sender_domain_totalscore=64355 rbsscore=0.996321851895651 spamscore=0 recipient_to_sender_domain_totalscore=0 urlsuspectscore=0.9 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=7.0.1-1402240000 definitions=main-1412260076 X-FB-Internal: deliver Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Validated that this was actually using the unsigned comparison with gdb. Signed-off-by: Alex Gartrell --- drivers/net/tun.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index a5cbf67..6c63e21 100644 --- a/drivers/net/tun.c +++ b/drivers/net/tun.c @@ -1499,7 +1499,7 @@ static int tun_recvmsg(struct kiocb *iocb, struct socket *sock, goto out; } ret = tun_do_read(tun, tfile, &m->msg_iter, flags & MSG_DONTWAIT); - if (ret > total_len) { + if (ret > (ssize_t)total_len) { m->msg_flags |= MSG_TRUNC; ret = flags & MSG_TRUNC ? ret : total_len; }