From patchwork Mon Nov 17 09:51:22 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Lothar_Wa=C3=9Fmann?= X-Patchwork-Id: 411479 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4492414012F for ; Mon, 17 Nov 2014 20:51:48 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752202AbaKQJvn (ORCPT ); Mon, 17 Nov 2014 04:51:43 -0500 Received: from mail.karo-electronics.de ([81.173.242.67]:53266 "EHLO mail.karo-electronics.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752025AbaKQJvl (ORCPT ); Mon, 17 Nov 2014 04:51:41 -0500 From: =?UTF-8?q?Lothar=20Wa=C3=9Fmann?= To: "David S. Miller" Cc: =?UTF-8?q?Lothar=20Wa=C3=9Fmann?= , netdev@vger.kernel.org, Frank Li , Fugang Duan , Russell King Subject: [PATCH 6/8] net: fec: use swab32s() instead of cpu_to_be32() Date: Mon, 17 Nov 2014 10:51:22 +0100 Message-Id: <1416217884-20911-7-git-send-email-LW@KARO-electronics.de> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1416217884-20911-1-git-send-email-LW@KARO-electronics.de> References: <1416217884-20911-1-git-send-email-LW@KARO-electronics.de> MIME-Version: 1.0 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org when swap_buffer() is being called, we know for sure, that we need to byte swap the data. Furthermore, this function is called for swapping data in both directions. Thus cpu_to_be32() is semantically not correct for all use cases. Use swab32s() to reflect this. Signed-off-by: Lothar Waßmann --- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 3884dd9..f73fee7 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -293,7 +293,7 @@ static void *swap_buffer(void *bufaddr, int len) unsigned int *buf = bufaddr; for (i = 0; i < DIV_ROUND_UP(len, 4); i++, buf++) - *buf = cpu_to_be32(*buf); + swab32s(buf); return bufaddr; }