From patchwork Sat Nov 8 16:18:02 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tina Johnson X-Patchwork-Id: 408370 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 4A9DE140079 for ; Sun, 9 Nov 2014 03:20:27 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753904AbaKHQUA (ORCPT ); Sat, 8 Nov 2014 11:20:00 -0500 Received: from mail-pd0-f173.google.com ([209.85.192.173]:39524 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753725AbaKHQT7 (ORCPT ); Sat, 8 Nov 2014 11:19:59 -0500 Received: by mail-pd0-f173.google.com with SMTP id v10so5147548pde.32 for ; Sat, 08 Nov 2014 08:19:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=xBApoA8JYkIR0bSit8VOXecAiyo3FBJrS6VH+o5cFyQ=; b=Dbiat1tEj/EJGzJ+/evq+4bPMAgGqsLCPau16+tiXB+2DFxq8sOdg1XHoj3jqaTCQH opSpkhH4DU/IsZAFV5q/Y8ezEg5xf2ykmLBWJl7UIOnkGUaPoyxtqKniquG7G7W7DoWP +JjltjDoxPg0NS/Dp7q1yBc7jfBhbNQaFakiMjU8DmFQNKE1i7H4EK+Oatf1y2IbFzlA mipEe0LzshoBL/Eu+Mtyq1m4lxVrr3tdSOcIbCMeF9N0ym3dN8/PWfSSewt4eX5g1nNa tN3wBVEUIi57oclx5XcS13vJU1OfW8D82WIk9iDfrv8JTBYbR266a5l8Lxp1hprE5vke rvtA== X-Received: by 10.68.100.197 with SMTP id fa5mr20582300pbb.22.1415463598455; Sat, 08 Nov 2014 08:19:58 -0800 (PST) Received: from localhost ([117.252.17.35]) by mx.google.com with ESMTPSA id gy10sm11836577pbd.67.2014.11.08.08.19.56 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 08 Nov 2014 08:19:57 -0800 (PST) From: Tina Johnson To: chas@cmf.nrl.navy.mil Cc: linux-atm-general@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, julia.lawall@lip6.fr, Tina Johnson Subject: [PATCH] drivers: atm: eni: Add pci_dma_mapping_error() call Date: Sat, 8 Nov 2014 21:48:02 +0530 Message-Id: <1415463482-8013-1-git-send-email-tinajohnson.1234@gmail.com> X-Mailer: git-send-email 1.7.10.4 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Added a pci_dma_mapping_error() call to check for mapping errors before further using the dma handle. Unchecked dma handles were found using Coccinelle: @rule1@ expression e1; identifier x; @@ *x = pci_map_single(...); ... when != pci_dma_mapping_error(e1,x) Signed-off-by: Tina Johnson Acked-by: Julia Lawall --- drivers/atm/eni.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/atm/eni.c b/drivers/atm/eni.c index d65975a..6450a36 100644 --- a/drivers/atm/eni.c +++ b/drivers/atm/eni.c @@ -356,6 +356,8 @@ static int do_rx_dma(struct atm_vcc *vcc,struct sk_buff *skb, if (skb) { paddr = pci_map_single(eni_dev->pci_dev,skb->data,skb->len, PCI_DMA_FROMDEVICE); + if (pci_dma_mapping_error(eni_dev->pci_dev, paddr)) + goto trouble; ENI_PRV_PADDR(skb) = paddr; if (paddr & 3) printk(KERN_CRIT DEV_LABEL "(itf %d): VCI %d has "