From patchwork Fri Oct 24 02:12:09 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 402725 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id C0D3D140081 for ; Fri, 24 Oct 2014 13:15:10 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755194AbaJXCPD (ORCPT ); Thu, 23 Oct 2014 22:15:03 -0400 Received: from mail-pa0-f49.google.com ([209.85.220.49]:50675 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbaJXCPC (ORCPT ); Thu, 23 Oct 2014 22:15:02 -0400 Received: by mail-pa0-f49.google.com with SMTP id hz1so225793pad.8 for ; Thu, 23 Oct 2014 19:15:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=FsUj0M3vq8MIB7Y8YkbyOWPaovDA9zbxAAk4IuWzvds=; b=V7x9d5hW1SOAFYrc27XSJBjYhyrSdnsNwnuEFjxgDS+RB+BGqdhGb/l1UR/p+uQrRn EZ+n0/Tya1SAWdk0EtvWEpKvDMTOxchJKM4yW123uhWmqzvmSpEhYZ+bMG4OB14qX6sS AFhj6mcgYRdoQuxWX4CyYkST3fFk3lLq6TcZ0YZo1j+qDcRj4oXjAO7/VQBBr21VKKbT cFCYmC7hYYU+dwU6BxLh8fPCMrat/GXkOBaeLt3zWnY0/tvahf8pO78fXqhiYNtayGH9 +CxGIrobHVs9NXRwOEdE5jYetvVRkcLuATYglLbBTOqBmyzPQBeL62CgPVN1XjIk+60U a0Cw== X-Received: by 10.67.29.177 with SMTP id jx17mr1609743pad.56.1414116901932; Thu, 23 Oct 2014 19:15:01 -0700 (PDT) Received: from bujji.202.153.32.3 ([175.101.63.212]) by mx.google.com with ESMTPSA id xy3sm2603985pbb.38.2014.10.23.19.14.44 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Oct 2014 19:15:00 -0700 (PDT) From: Varka Bhadram X-Google-Original-From: Varka Bhadram To: netdev@vger.kernel.org Cc: davem@davemloft.net, sergei.shtylyov@cogentembedded.com, Varka Bhadram Subject: [PATCH net-next v3 4/5] ethernet: renesas: remove unnecessary check Date: Fri, 24 Oct 2014 07:42:09 +0530 Message-Id: <1414116730-4590-5-git-send-email-varkab@cdac.in> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1414116730-4590-1-git-send-email-varkab@cdac.in> References: <1414116730-4590-1-git-send-email-varkab@cdac.in> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org devm_ioremap_resource checks platform_get_resource() return value. We can remove the duplicate check here. Signed-off-by: Varka Bhadram --- drivers/net/ethernet/renesas/sh_eth.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c index 60e9c2c..dbe8606 100644 --- a/drivers/net/ethernet/renesas/sh_eth.c +++ b/drivers/net/ethernet/renesas/sh_eth.c @@ -2769,10 +2769,6 @@ static int sh_eth_drv_probe(struct platform_device *pdev) /* get base addr */ res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (unlikely(res == NULL)) { - dev_err(&pdev->dev, "invalid resource\n"); - return -EINVAL; - } ndev = alloc_etherdev(sizeof(struct sh_eth_private)); if (!ndev) @@ -2781,8 +2777,6 @@ static int sh_eth_drv_probe(struct platform_device *pdev) pm_runtime_enable(&pdev->dev); pm_runtime_get_sync(&pdev->dev); - /* The sh Ether-specific entries in the device structure. */ - ndev->base_addr = res->start; devno = pdev->id; if (devno < 0) devno = 0; @@ -2806,6 +2800,8 @@ static int sh_eth_drv_probe(struct platform_device *pdev) goto out_release; } + ndev->base_addr = res->start; + spin_lock_init(&mdp->lock); mdp->pdev = pdev;