From patchwork Sat Jul 30 09:13:17 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 654262 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 3s1fzn3WMRz9t1G for ; Sat, 30 Jul 2016 19:14:13 +1000 (AEST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751248AbcG3JN5 (ORCPT ); Sat, 30 Jul 2016 05:13:57 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:64276 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750833AbcG3JNz (ORCPT ); Sat, 30 Jul 2016 05:13:55 -0400 Received: from wuerfel.localnet ([78.42.132.4]) by mrelayeu.kundenserver.de (mreue102) with ESMTPSA (Nemesis) id 0MA5Q9-1baFom1PS5-00BM73; Sat, 30 Jul 2016 11:13:21 +0200 From: Arnd Bergmann To: Iyappan Subramanian Cc: davem@davemloft.net, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@apm.com, linux@armlinux.org.uk Subject: Re: [PATCH net-next 01/10] drivers: net: xgene: Fix kbuild warning Date: Sat, 30 Jul 2016 11:13:17 +0200 Message-ID: <14140485.FlkQbu0aHJ@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-31-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <1469838843-19943-2-git-send-email-isubramanian@apm.com> References: <1469838843-19943-1-git-send-email-isubramanian@apm.com> <1469838843-19943-2-git-send-email-isubramanian@apm.com> MIME-Version: 1.0 X-Provags-ID: V03:K0:tFEOXElVEWws1qJLxU0PfiQGdKSlqHyZ9hTHf2sBc6zqkUvRPL5 ezUQXJ428SLBVPHjiIIpVpY527b5YoBd05F6GTQIdAEjH+YsNLS0eWHGGu1RduCV62EJFzH CT/kS6P1crFmQi5nb/XQokFMb8cmfghSqORwdfcA9UjmM0Tl7wukq2z1oFIj1bKk9yg9Xp9 89S0+cD0E+vn0E4Kk7tow== X-UI-Out-Filterresults: notjunk:1; V01:K0:rLOOv7Qxsso=:NujxLrUWFzstlfsUuVmO6D Dj2y2Jztq1KBSq/8Ko3Xm0PkJtiJanU0yVurwHTXM2kbwlwMRmUIPpV+9/ElRkafPjnjkd6PY JLdiAXrfghAlbnyUNJ+wgmuTCefMPks5cKdneC4h+jCQsgtRZ0QtXQbPFW7DbEobGfWWtvZFX DzFv2buDYZBl8npd9e/0YnCEBaLXKZGsDNVpZ58Ga+heMXPq5lzjUau1gigsfU5yIR4dKjxjJ AQUnjEkxLSgPNP5vCweqUprwBFdgB32OZqEs0FjRfFTKec2lqojQ6RBCaWG6+VSEia52xKypJ 39D2u1UbmMmmhVoGn0rMCpdR3+DGB1AL7FChiTQ3ZAtSFnpyeiI7U3WdUVe892MPCWGn/bhrC dXJydy4dXirzMv8HHicrn9xO8EpPy8y/8b10Vy/v5Kw55RGa0PfbvICMaQCPN7kFY5w4F+hoY wI54/rGwNwxztxYgbUGalgLiv1aX+NktDabxxojNEo2FL+CtSp+PCgwbQ3cIQ9gU4QB/zP7qX HE4YbywuwjJp3o0zrzjVVHB9CIm80zzEeBdKhq2WsdZZzuhavdkfPd4bvDXH2rWscI2+jD0TY QUtZ9VrLwao5vY7njSKHrJvvdOpHQapmaJe8fMtmifRurAumvvbpufOD0p16S1s1B05HODpHl pCPtU8q6u+sis9VWMxdQ9W8Lz7w4fASRKdLx2ZLvT1c80MMFwmRXlPBDvsU95yGqEiWXmhMCx QxkQbHM4T0Gf5vvJ Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Friday, July 29, 2016 5:33:54 PM CEST Iyappan Subramanian wrote: > This patch fixes the following kbuild warning, when ACPI was not enabled. > > >> drivers/net/ethernet/apm/xgene/xgene_enet_hw.c:878:23: warning: 'phy_dev' may be used uninitialized in this function [-Wmaybe-uninitialized] > phy_dev->advertising = phy_dev->supported; From looking at the patch, I don't think it addresses the warning. Note that Linus added a patch to disable the warning in the latest mainline kernel, so you won't see it any more, but I think the bug is still there. > diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c > index 7714b7d..b6bc6fa 100644 > --- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c > +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c > @@ -776,15 +776,11 @@ int xgene_enet_phy_connect(struct net_device *ndev) > netdev_err(ndev, "Could not connect to PHY\n"); > return -ENODEV; > } > - > - pdata->phy_dev = phy_dev; > } else { > #ifdef CONFIG_ACPI > struct acpi_device *adev = acpi_phy_find_device(dev); > if (adev) > - pdata->phy_dev = adev->driver_data; > - > - phy_dev = pdata->phy_dev; > + phy_dev = adev->driver_data; > > if (!phy_dev || > phy_connect_direct(ndev, phy_dev, &xgene_enet_adjust_link, > @@ -795,6 +791,7 @@ int xgene_enet_phy_connect(struct net_device *ndev) > #endif > } > > + pdata->phy_dev = phy_dev; phy_dev is not initialized anywhere if CONFIG_ACPI is not set and dev->of_node is NULL (which should not happen in practice, but the compiler doesn't know that). I think you want this instead: ARnd Arnd diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c index 7714b7d4026a..98779fe2d558 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_hw.c @@ -792,6 +792,8 @@ int xgene_enet_phy_connect(struct net_device *ndev) netdev_err(ndev, "Could not connect to PHY\n"); return -ENODEV; } +#else + return -ENODEV; #endif }