From patchwork Wed Oct 22 04:16:23 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Varka Bhadram X-Patchwork-Id: 401881 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 904FF140081 for ; Wed, 22 Oct 2014 15:20:01 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753121AbaJVETm (ORCPT ); Wed, 22 Oct 2014 00:19:42 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:47614 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbaJVETj (ORCPT ); Wed, 22 Oct 2014 00:19:39 -0400 Received: by mail-pa0-f46.google.com with SMTP id fa1so2836817pad.19 for ; Tue, 21 Oct 2014 21:19:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=snjAKDtHSP8Uv0QARJJOWPFDL55mOQ8g0FBAieuE0ys=; b=gcJWEVwTxNQqXMWO8yxeBdT39CwvRzDkIwUDckV8evdXsvXj3u+peNopcHnfgjJzhl kqPa0FrW6yjP3Xjl6PbND8NjdOpyh7SfUIzYhHIQktzxbg9ck5FyXO/uudzkVz6tbcUE JSrnAuXmWgxA4CltFOI+h7NT5k2ePAyJQoKPfcLlE8+WA5Ytnqp9hW4O6bCAoYLr9aMl JUXtX2HdVbWRCNZ2VhJSYb1yxaIaqfF0G3eLz8oIZvyIsA0mOxjY1wKN0RhvzGC6KGfQ PMqwIwCr7ccOSIePWJleg3GKlW4OIYs4vCCPLPHGUMe/d0uoErB3X6M0Wu/M8yDG+CyB oIdw== X-Received: by 10.70.23.163 with SMTP id n3mr40448879pdf.0.1413951579455; Tue, 21 Oct 2014 21:19:39 -0700 (PDT) Received: from cdac.hyderabad.cdac.in ([196.12.45.164]) by mx.google.com with ESMTPSA id g3sm13254243pdh.33.2014.10.21.21.19.36 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 21 Oct 2014 21:19:38 -0700 (PDT) From: Varka Bhadram X-Google-Original-From: Varka Bhadram To: netdev@vger.kernel.org Cc: Varka Bhadram Subject: [PATCH net-next 3/6] ethernet: apm: xgene: remove unnecessary check Date: Wed, 22 Oct 2014 09:46:23 +0530 Message-Id: <1413951386-29645-4-git-send-email-varkab@cdac.in> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1413951386-29645-1-git-send-email-varkab@cdac.in> References: <1413951386-29645-1-git-send-email-varkab@cdac.in> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org devm_ioremap_resource checks platform_get_resource() return value. We can remove the duplicate check here. Signed-off-by: Varka Bhadram --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c index 3c208cc..f226594 100644 --- a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c +++ b/drivers/net/ethernet/apm/xgene/xgene_enet_main.c @@ -761,10 +761,6 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata) ndev = pdata->ndev; res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "enet_csr"); - if (!res) { - dev_err(dev, "Resource enet_csr not defined\n"); - return -ENODEV; - } pdata->base_addr = devm_ioremap_resource(dev, res); if (IS_ERR(pdata->base_addr)) { dev_err(dev, "Unable to retrieve ENET Port CSR region\n"); @@ -772,10 +768,6 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata) } res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ring_csr"); - if (!res) { - dev_err(dev, "Resource ring_csr not defined\n"); - return -ENODEV; - } pdata->ring_csr_addr = devm_ioremap_resource(dev, res); if (IS_ERR(pdata->ring_csr_addr)) { dev_err(dev, "Unable to retrieve ENET Ring CSR region\n"); @@ -783,10 +775,6 @@ static int xgene_enet_get_resources(struct xgene_enet_pdata *pdata) } res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "ring_cmd"); - if (!res) { - dev_err(dev, "Resource ring_cmd not defined\n"); - return -ENODEV; - } pdata->ring_cmd_addr = devm_ioremap_resource(dev, res); if (IS_ERR(pdata->ring_cmd_addr)) { dev_err(dev, "Unable to retrieve ENET Ring command region\n");